Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to load dictionaries in memory #6

Open
nvx opened this issue Feb 17, 2020 · 1 comment
Open

Ability to load dictionaries in memory #6

nvx opened this issue Feb 17, 2020 · 1 comment

Comments

@nvx
Copy link

nvx commented Feb 17, 2020

At the moment it is only possible to load dictionaries from disk. This precludes storing dictionaries in a database or other more easily updated location that an application could load from on startup.

Would there be any objections to exposing the inner for loop body of the indexDictionaries func outside of the package so that the dictionary could be populated by whatever is convenient for the developer with a caveat that it is not safe to call that function concurrently with any other aspect of the application (or a rwmutex to enforce that this is the case).

@muesli
Copy link
Owner

muesli commented Feb 25, 2020

I guess we could just make it support any io.Reader interface? Certainly no objections to such a change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants