Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split core types into a core subpackage #131

Closed
Stebalien opened this issue Jun 12, 2020 · 1 comment
Closed

Split core types into a core subpackage #131

Stebalien opened this issue Jun 12, 2020 · 1 comment
Labels
exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@Stebalien
Copy link
Member

Currently, the core Multihash type and the Sum function are defined in the same package. This means anyone who wants to import the type also needs to import the sum function, pulling in all the hashing libraries at the same time.

Instead, we should:

  • Split the core types/functions into a core sub package.
  • Add type aliases in the root package to the types moved to the core package.
  • Keep Sum in the root package.

That way, packages that depend on these types can directly import the core package, reducing binary size.

Replaces #78.

@Stebalien Stebalien added kind/enhancement A net-new feature or improvement to an existing feature exp/expert Having worked on the specific codebase is important P3 Low: Not priority right now labels Jun 12, 2020
@warpfork
Copy link
Contributor

I believe this is now closed by #136 🎉

(If there's additional specific work this didn't cover yet, it probably could use a fresh issue to enumerate it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

2 participants