Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendme send . causes silent exit without error message #43

Open
stackinspector opened this issue Aug 2, 2024 · 4 comments
Open

sendme send . causes silent exit without error message #43

stackinspector opened this issue Aug 2, 2024 · 4 comments

Comments

@stackinspector
Copy link

sending current directory will cause a file occupied error while iterating to the db file that just created, and any errors will cause the program to exit silently.
In my opinion, an ad-hoc tool can show its raw errors regardless of whether the user can read them or not, but it can't ignore them and exit silently! The current approach is tantamount to unwraping on every Results and setting panic behavior to abort!

@stackinspector
Copy link
Author

This problem could only be found on Windows due to the different policies for handling file locks between Windows and Linux/macOS.

@stackinspector
Copy link
Author

I was wrong. unwrap-then-abort leaves error message at least.

@matheus23
Copy link
Contributor

Agreed. This should be better.
What would you expect sendme send . to do? Error out or ignore the data directory that contains the blobs.db?

@jerzydziewierz
Copy link

jerzydziewierz commented Aug 13, 2024

IMHO, I would expect it to ignore it's own, sendme related files, but attempt to send everything else; possibly also ignore dot-prefixed files and directories, and also ignore files as per .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants