-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing cyclomatic complexity #196
Comments
We've requested this, and static analysis through the IVV SWAT team. Have not heard back after the initial request. Provided them with the URL to the repository. Just awaiting a response. Will check back in next week if we haven't heard anything by then. |
Touched base with SWAT again. Still awaiting setup on this. |
Complexity format has been updated on IVV side. Readable results now. Have started a spreadsheet with these initial results. Many things are not all that complex, and should remain as they are. However, our Apply/Process functions could use some discussion. Have put in a request with IVV to rerun our job with the latest dev branch, rather than just main. This should give us some more results. |
These changes are getting very large. May be worth the time to slowly chunk these up into small pieces for easier merge review. Ideally different issues and merges for each section you're refactoring. |
Will create new issues for the remaining refactors first. If we want to separate the currently refactored portions, I can do that as well. |
For additional reference, the following functions have been refactored within this issue:
sadb_routine_inmemory_template.c:
crypto.c:
cryptography_interface_lib_gcrypt_template.c:
base64url.c:
standalone.c:
|
Currently, there is also some crypto_tm.c refactoring (tm_apply) - but it is not yet finished. I'm going to leave at least the one partially finished in this branch. I'll probably move the process functionality to its own branch. |
…ypto_tc.c - Modify several single returns
Need to generate cyclomatic complexity and reduce it to accommodate NASA Class B FSW standards.
The text was updated successfully, but these errors were encountered: