Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Two Images with One Image #905

Open
katblanchette opened this issue Oct 28, 2024 · 4 comments
Open

Replace Two Images with One Image #905

katblanchette opened this issue Oct 28, 2024 · 4 comments
Labels
Lesson: 1 Module: 2 OS101 Curriculum: Graphic Suggestions Suggestions for graphics found in the open science 101 curriculum. Use Lesson and Module Labels. OS101 Status: Curriculum Openscience101.org still needs changes implemented.

Comments

@katblanchette
Copy link

katblanchette commented Oct 28, 2024

https://github.com/nasa/Transform-to-Open-Science/tree/open-science-101/Module_2/Lesson_1#open-research-products - @bressler1995 - Will you delete the puzzle piece graphic with Metadata, Measurements, Facts, and statics. We do not want to replace that graphic. Replace the venn diagram graphic with the professor graphic (Science Data). Here is the link to the new graphic - Link. Also, update the 1st sentence to include the terms from the Venn Diagram. It will now read... "Scientific knowledge, or research products, take the form of data, results, code, and software." Then, move the 2nd sentence that reads... "Within these research products are additional types of products, such as methodologies, algorithms, and physical artifacts." . Then, add the image linked above. Thank you! Katherine

Thank you!

@bressler95tops bressler95tops added OS101 Curriculum: Graphic Suggestions Suggestions for graphics found in the open science 101 curriculum. Use Lesson and Module Labels. Module: 2 Lesson: 1 OS101 Status: Curriculum Openscience101.org still needs changes implemented. OS101 Status: GitHub GitHub still needs changes implemented. labels Nov 4, 2024
bressler1995 added a commit to bressler1995/Transform-to-Open-Science that referenced this issue Nov 5, 2024
bressler95tops added a commit that referenced this issue Nov 5, 2024
Address Open Science 101 suggestion in issue #905
@bressler95tops
Copy link
Contributor

@katblanchette I got this done in PR #917 for your reference. As always view the 'files changed' tab when you view the PR. I did notice that the professor image made it into the MOOC but the first sentence change did not. Maybe this was intentional to wait on Olha's work but I just figured I would let you know just in case.

@bressler95tops bressler95tops removed the OS101 Status: GitHub GitHub still needs changes implemented. label Nov 5, 2024
@katblanchette
Copy link
Author

@bressler95tops - Thank you for updating the graphic! The change looks good and the OS101 Team thanks you for your efforts. Please close this issue when you are ready.

@bressler95tops
Copy link
Contributor

@katblanchette I see that the image was replaced in the MOOC but not the new sentence that you mentioned. So I will keep this open for now, maybe we can make this a round two item.

@bressler95tops
Copy link
Contributor

This is the exact change that needs to happen @katblanchette https://github.com/nasa/Transform-to-Open-Science/pull/917/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lesson: 1 Module: 2 OS101 Curriculum: Graphic Suggestions Suggestions for graphics found in the open science 101 curriculum. Use Lesson and Module Labels. OS101 Status: Curriculum Openscience101.org still needs changes implemented.
Projects
None yet
Development

No branches or pull requests

2 participants