Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI checks first as part of CD workflow #448

Open
lorenyu opened this issue Sep 14, 2023 · 0 comments
Open

Run CI checks first as part of CD workflow #448

lorenyu opened this issue Sep 14, 2023 · 0 comments
Labels
scope: ci/cd GitHub actions workflows type: feature New feature or new functionality to existing feature workflow: needs refinement Further information is requested

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Sep 14, 2023

The CD App workflow right now deploys to dev environment on merges to main, and separately the CI App workflows (e.g. flask template ci-app and nextjs template ci-app also run on merges to main). This ticket is to have the deploys only continue if the CI checks pass.

This ticket has some complexity since it crosses the boundaries between templates. We need to do at least the following:

  • Update the ci-app workflows in the Nextjs and Flask templates to get rid of the push to main trigger and to instead include a workflow_call trigger so it can be triggered by cd-app
  • Update the cd-app.yml workflow in Infra template to call the ci-app workflow (it won't exist in template-infra but that's ok since this workflow doesn't actually get called directly in template-infra)
  • Update application-requirements.md to add a requirement that the application has a ci-<APP_NAME>.yml workflow

credit to @daphnegold for the suggestion

@lorenyu lorenyu added scope: ci/cd GitHub actions workflows type: feature New feature or new functionality to existing feature labels Sep 14, 2023
@lorenyu lorenyu modified the milestone: Multiple applications Sep 14, 2023
@lorenyu lorenyu added the workflow: needs refinement Further information is requested label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: ci/cd GitHub actions workflows type: feature New feature or new functionality to existing feature workflow: needs refinement Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant