Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different emojis for failure and error #65

Open
piranna opened this issue Jun 24, 2023 · 6 comments · May be fixed by #66
Open

Use different emojis for failure and error #65

piranna opened this issue Jun 24, 2023 · 6 comments · May be fixed by #66

Comments

@piranna
Copy link

piranna commented Jun 24, 2023

node-test-github-reporter/index.js

Lines 99 to 100 in b600d81

if (test.failure || test.error) {
return ':x:'

I would use 💀 (:skull:) for failure, since most of the cases a test fails is because it died.
@simoneb
Copy link
Member

simoneb commented Jun 24, 2023

Thanks for reporting this. I would prefer to keep the emojis agnostic from any human connotation, but if you would like to send a PR to make them configurable, feel free to do so.

@piranna
Copy link
Author

piranna commented Jun 24, 2023

It's mostly about differenciate between failures and errors, because they are not the same, failures are errors in the tests themselves (they are broken) instead of the code they are testing, so 🏚️ (:derelict_house:) could also works.

@simoneb
Copy link
Member

simoneb commented Jun 24, 2023

Yes agreed. I asked ChatGPT to come up with a list of emojis that could represent something that's an error, and it came up with this. Any preference?

❌ Cross Mark
🚫 No Entry Sign
⚠️ Warning Sign
🛑 Stop Sign
🚨 Police Car Light
🚫🔧 Wrench and No Entry Sign
🚩 Triangular Flag
🆘 SOS Button
💥 Collision Symbol
📛 Name Badge

@piranna
Copy link
Author

piranna commented Jun 24, 2023

Of these ones, 💥 (:boom:) I think is the best one for failures.

What prompt did you used?

@simoneb
Copy link
Member

simoneb commented Jun 24, 2023

Let's go with that then. Mind sending a tiny PR for this?

As for the prompt:

show me emojis for something that's an error

@piranna
Copy link
Author

piranna commented Jun 24, 2023

Mind sending a tiny PR for this?

You have it at #66

@piranna piranna linked a pull request Jun 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

💥 emoji for failures piranna/node-test-github-reporter
2 participants
@simoneb @piranna