From 157ebc67a34e9710dcf5ed56ab628d0dad033c16 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sun, 30 Jun 2024 10:09:48 +0200 Subject: [PATCH] TASK: Remove b/c layer `CommandResult::block()` --- .../Classes/CommandHandler/CommandResult.php | 14 +++++--------- .../Classes/ContentRepository.php | 4 ---- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/Neos.ContentRepository.Core/Classes/CommandHandler/CommandResult.php b/Neos.ContentRepository.Core/Classes/CommandHandler/CommandResult.php index 515309a4974..626a2b56381 100644 --- a/Neos.ContentRepository.Core/Classes/CommandHandler/CommandResult.php +++ b/Neos.ContentRepository.Core/Classes/CommandHandler/CommandResult.php @@ -12,16 +12,12 @@ * * This will no longer be required in the future see https://github.com/neos/neos-development-collection/pull/4988 * - * @deprecated this b/c layer will be removed with the next beta or before Neos 9 final release - * @api + * TODO decide whether it might be useful to have some return type that tells something about the published events + * (e.g. last sequence number) and maybe even about the updated/skipped projections + * see discussion: https://github.com/neos/neos-development-collection/pull/5061#issuecomment-2117643465 + * + * @internal this object will either be transformed into something useful and made API or deleted. */ final readonly class CommandResult { - /** - * We block by default thus you must not call this method or use this legacy stub - * @deprecated this b/c layer will be removed with the next beta or before Neos 9 final release - */ - public function block(): void - { - } } diff --git a/Neos.ContentRepository.Core/Classes/ContentRepository.php b/Neos.ContentRepository.Core/Classes/ContentRepository.php index f6fc32cbc0e..fdb6d520c8f 100644 --- a/Neos.ContentRepository.Core/Classes/ContentRepository.php +++ b/Neos.ContentRepository.Core/Classes/ContentRepository.php @@ -90,10 +90,6 @@ public function __construct( /** * The only API to send commands (mutation intentions) to the system. * - * The system is ASYNCHRONOUS by default, so that means the projection is not directly up to date. If you - * need to be synchronous, call {@see CommandResult::block()} on the returned CommandResult - then the system - * waits until the projections are up to date. - * * @param CommandInterface $command * @return CommandResult */