WONT FIX? Inconsistency setProperty(null) on node will not be stored in some cases

[mhsdesign]

About the old CR. Neos 8.3

If you have a node with those properties defined:

properties:
  withDefault:
    defaultValue: false
    type: boolean
  withoutDefault:
    type: boolean

// will be stored (eg $node->hasProperty())
$node->setProperty("withDefault", null);

// will not be stored (eg $node->hasProperty())
$node->setProperty("withoutDefault", null);

// will also not be stored (eg $node->hasProperty())
$node->setProperty("undeclaredProperty", null);

// will be stored (eg $node->hasProperty())
$node->setProperty("anotherUndeclaredProperty", "hi");
$node->setProperty("anotherUndeclaredProperty", null);

the cause for this behavior is this guard:

neos-development-collection/Neos.ContentRepository/Classes/Domain/Model/Node.php

Lines 872 to 874 in 1b744c8

	if (!is_object($value) && !is_array($value) && $this->getProperty($propertyName) === $value) {
	return;
	}

we should also make sure that $node->hasProperty in that case.

But i dont think its worth bugfixing this minor inconsistency and this might never be a real problem.
We just wondered what was going on @Sebobo

[mhsdesign]

in neos 9 the handling of null is much more consistent. As null always works as a unset. (at least it does now after #4322)

• NOTE: if a value is set to NULL in SerializedPropertyValues, this means the key should be unset,
• because we treat NULL and "not set" the same from an API perspective.

neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/NodeModification/Event/NodePropertiesWereSet.php

Lines 32 to 33 in 782b958

	* NOTE: if a value is set to NULL in SerializedPropertyValues, this means the key should be unset,
	* because we treat NULL and "not set" the same from an API perspective.

implementation:

the merge will also do an array_filter:

neos-development-collection/Neos.ContentGraph.DoctrineDbalAdapter/src/DoctrineDbalContentGraphProjection.php

Line 788 in bb55e5f

$node->properties = $node->properties->merge($event->propertyValues);