Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Config Presets #4582

Closed
bwaidelich opened this issue Oct 6, 2023 · 4 comments · Fixed by #4735
Closed

Site Config Presets #4582

bwaidelich opened this issue Oct 6, 2023 · 4 comments · Fixed by #4735
Assignees

Comments

@bwaidelich
Copy link
Member

bwaidelich commented Oct 6, 2023

Similar to ContentRepository presets it might be useful to be able to define presets for site configurations and potentially ship a default preset with Neos.Neos.

So instead of:

Neos:
  Neos:
    sites:
      '*':
        uriPathSuffix: '.html'
        contentRepository: default
        contentDimensions:
          resolver:
            factoryClassName: Neos\Neos\FrontendRouting\DimensionResolution\Resolver\AutoUriPathResolverFactory

we could have something like:

Neos:
  Neos:
    sitePresets:
      'default':
        uriPathSuffix: '.html'
        contentRepository: default
        contentDimensions:
          resolver:
            factoryClassName: Neos\Neos\FrontendRouting\DimensionResolution\Resolver\AutoUriPathResolverFactory
    sites:
      'my-site-node-name':
        preset: 'default'
@bwaidelich bwaidelich converted this from a draft issue Oct 6, 2023
@mhsdesign
Copy link
Member

is this a breaking change?

@mhsdesign mhsdesign moved this from Todo to Low Priority in Neos 9.0 Release Board Nov 10, 2023
@bwaidelich
Copy link
Member Author

is this a breaking change?

mh.. yes. Unless we decide to keep supporting * and translate it to some preset on the fly

@mhsdesign
Copy link
Member

Question is how we should prioritise this for 9.0

@bwaidelich
Copy link
Member Author

Question is how we should prioritise this for 9.0

#4735 is already an important improvement and it's fully(tm) backwards compatible. So I'd say we should not prioritize this, but merge it as preparation for potential further improvements (like the reworked site entity)

@bwaidelich bwaidelich moved this from In Progress 🚧 to Under Review 👀 in Neos 9.0 Release Board Apr 26, 2024
@github-project-automation github-project-automation bot moved this from Under Review 👀 to Done ✅ in Neos 9.0 Release Board Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants