Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: "Connect" new site entity to site node #4918

Open
mhsdesign opened this issue Mar 4, 2024 · 3 comments
Open

FEATURE: "Connect" new site entity to site node #4918

mhsdesign opened this issue Mar 4, 2024 · 3 comments

Comments

@mhsdesign
Copy link
Member

The really hacky way to import a neos site is like

  1. ./flow cr:setup
  2. ./flow site:create neosdemo Neos.Demo Neos.Demo:Document.Homepage
  3. ./flow cr:prune
  4. ./flow cr:import resource://Neos.Demo/Private/Content

Originally the neos 9 site:create would create a site entity and a site node, but its actually completely unnecessary to create an event stream just to prune it one second later.

With this change #4248
./flow site:create becomes rather a "create only site entity if site node exists already".

Which allows to simplify the above steps to

  1. ./flow cr:setup
  2. ./flow cr:import resource://Neos.Demo/Private/Content
  3. ./flow site:create neosdemo Neos.Demo Neos.Demo:Document.Homepage

Still the site create step is confusing as the $nodeType argument is only used for validation but not used as a sideNode exists already.

The whole site entity <-> site node relation is a bit hard to grasp as one can see by the discussions in #4470

Also we strive for an export which will include the site entity also (so that its a simple one step like ./flow cr:import resource://Neos.Demo/Private/Content) #4448

But this issue should discuss how the usecase of having a even-stream dump and how to connect a site entity to it should work.
Its not unlikely that passing eventstreams along for debugging will become a habit, so we should make it easy to find out which site nodes exist in graph projection vs which site entities you have.

Maybe we even have to go more manual, if we cant cleanly fix the site entity <-> site node relation and make it all work out of the bod, and add sitenode:create or site:connecttonode or site:showunconnected

@bwaidelich
Copy link
Member

@mficzel am I right that you'll address this with #4448?

@mficzel
Copy link
Member

mficzel commented Oct 23, 2024

@bwaidelich is think this is covered now. You can either run ./flow site:importAll Neos.Demo to import an existing export or create a new empty site via ./flow site:create neosdemo Neos.Demo Neos.Demo:Document.Homepage

Important site:create latter does not imply doctrine:migrate and cr:setup yet.

@mhsdesign
Copy link
Member Author

mhsdesign commented Nov 2, 2024

Thanks :) Maybe we should expose as said a low level site:create-only-neos-site command so when i for example get the event steam table of the starship i can import that, add new workspace metadata and adjust the site entity.

I think the event stream is the most important truth and anything else that neos attaches like workspace metadata, or site metadata (the site) is possibly out of sync and we should provide low level tools like flow workspace:assignrole live Neos.Neos:LivePublisher collaborator to adjust that. Same for the site.
And it should not only be possible to adjust it but also easy to detect what is out of sync. For that i already tried to create tooling here: #4900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants