Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully migrate ContentCacheFlusherTest to behat #5037

Closed
mhsdesign opened this issue May 9, 2024 · 2 comments · Fixed by #5263
Closed

Fully migrate ContentCacheFlusherTest to behat #5037

mhsdesign opened this issue May 9, 2024 · 2 comments · Fixed by #5263
Labels

Comments

@mhsdesign
Copy link
Member

There is this functional test leftover

class ContentCacheFlusherTest extends FunctionalTestCase

which has been migrated partially with #4788 but as @dlubitz pointed out

I'd say I didn't test the workspace chains.

so that should ideally be added to the new behat tests

mhsdesign added a commit that referenced this issue May 9, 2024
it will be fully migrated via #5037
neos-bot pushed a commit to neos/neos that referenced this issue May 11, 2024
@mhsdesign mhsdesign added the 9.0 label Jun 16, 2024
@dlubitz
Copy link
Contributor

dlubitz commented Sep 25, 2024

I think we can safely close this, as we improved the testing of the content cache flusher at all. And this specific case was just testing some implementation detail.

@mhsdesign
Copy link
Member Author

Thank uuuuu ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants