BUGFIX: Build URI path based on parent from "target" dimensionSpacePoint #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
reviewed
May 24, 2024
Comment on lines
+455
to
+458
| $uriPathSegment = basename($sourceNode->getUriPath()); | ||
| $uriPath = $parentNode->getUriPath() === '' | ||
| ? $uriPathSegment | ||
| : $parentNode->getUriPath() . '/' . $uriPathSegment; |
There was a problem hiding this comment.
I'm not sure how we "calculate" the uri path in other places, but I don't remember having used basename() (not that I dislike it, but IMO it should be unified – potentially centralized to some DocumentNodeInfo::withUriPathSegment(string $newSegment)!?
There was a problem hiding this comment.
Well, withUriPathSegment(…) does not help here, the basename(…) is used to get the segment I would need to pass here.
But I will get rid of basename and use code like in whenNodePropertiesWereSet(…) later in the class.
|
Yeah, I'll add a test. And I am confused, because I saw that work yesterday, and today it does no longer? 🤔 |
|
Hi what is the status here? ^^ |
|
Good question, lost track of this one… Will check! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a node variant via switching of dimensions, the URI path projection did not take the URI (path) of the (new) parent into account. The URI was the "original" URI, regardless of the potentially differing URI path segments in the variants of the "new parents".
Now a node variant has a URL built from it's parent(s) in it's own dimensions.
Fixes #5090
Upgrade instructions
If affected by the bug, you can run
./flow cr:projectionreplay 'Neos\Neos\FrontendRouting\Projection\DocumentUriPathProjection'to fix the projection.
Review instructions
Reproduction is described in the issue.
Checklist
The PR is created against the lowest maintained branchFEATURE|TASK|BUGFIX!!!and have upgrade-instructions