You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the CopyNodesRecursively command has two properties that reflect the inner working more than the original intention to copy existing nodes.
This is a problem because it allows to circumvent constraint checks.
Namely:
$nodeTreeToInsert that basically contains a serialized snapshot of all the affected nodes
$nodeAggregateIdMapping that creates new, random, node aggregate ids
Both should not happen at command creation time but in the command handler, i.e. we should introduce some CopyNodesRecursivelySerialized variants.
More importantly this will allow us to do proper constraint checks
Right, that's why they are mentioned in the 2nd phrase :)
bwaidelich
changed the title
Change CopyNodesRecursively command to capture _intent_
Change CopyNodesRecursively command to capture intent
Nov 11, 2024
Currently the CopyNodesRecursively command has two properties that reflect the inner working more than the original intention to copy existing nodes.
This is a problem because it allows to circumvent constraint checks.
Namely:
$nodeTreeToInsert
that basically contains a serialized snapshot of all the affected nodes$nodeAggregateIdMapping
that creates new, random, node aggregate idsBoth should not happen at command creation time but in the command handler, i.e. we should introduce some
CopyNodesRecursivelySerialized
variants.Related: #5353
The text was updated successfully, but these errors were encountered: