Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Usage backend module need overhaul #5438

Open
dlubitz opened this issue Jan 16, 2025 · 3 comments
Open

Asset Usage backend module need overhaul #5438

dlubitz opened this issue Jan 16, 2025 · 3 comments

Comments

@dlubitz
Copy link
Contributor

dlubitz commented Jan 16, 2025

After overhaul of the workspaces and workspace permissions the backend module to show asset usages is not working anymore as expected.

  • Workspace names/titles are not displayed anymore.
  • Differentiation between personal, internal and shared workspaces does not exist anymore.
  • Loading nodes for details in foreign workspaces leads to exception.
  • Template RelatedNodes.html access to non existing properties workspace.*
  • ...

Adapting these points leads to questions we should think through first.

  • Which workspace information is considered as secret?
    • Can we show the title of a workspace, even if the user has no access to it?
    • Can we show the NodeType of edited nodes within a Workspace without read permission?
    • Do we differenciate between user roles? (Admin vs. Editor)
@lorenzulrich
Copy link
Contributor

Wouldn't it make sense to working towards using the flowpack/media-ui by default? The shipped Media module is clearly inferior to media-ui and I think it would be a shame to direct more resources to it when there is a better replacement.

@Sebobo

@Sebobo
Copy link
Member

Sebobo commented Jan 21, 2025

For now it still makes sense to fix the displayed data in the usages without adding new features.

The questions regarding the shown workspaces information is also relevant for the Media.Ui as we need to show similar data there. @dlubitz you worked on that already in Flowpack/media-ui@main...neos-9. Isn't it basically similar?

IMO the next step could be that the Neos.Media.Browser is optional and that one or the other can be installed to fulfil a media management dependency, similarly to some other packages like redirecthandler-database-storage.
I think there are only a few hard dependencies in Neos.Neos and Neos.Ui that need to be adjusted.

I don't see the Media.Ui becoming part of the core packages soonish. Would be great though, if the agencies who modify the old Media.Browser help improve the Media.Ui instead to achieve the same.

@dlubitz
Copy link
Contributor Author

dlubitz commented Jan 21, 2025

I also don't see the new media-ui coming that soon. So we need something working for Neos 9.0.

It's rather an "update the current code to work as before just with Neos 9" than something new here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants