From 71abbee8dcc66537e9e1418ae7095f5f888abffb Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sun, 30 Jun 2024 10:15:23 +0200 Subject: [PATCH 1/7] TASK: Remove b/c layer `Node::$nodeAggregateId` --- .../Classes/Projection/ContentGraph/Node.php | 12 ------------ .../Classes/Domain/Repository/SiteRepository.php | 2 +- .../Private/Templates/Service/Nodes/Index.html | 4 ++-- .../Private/Templates/Service/Nodes/Show.html | 4 ++-- .../Features/Fusion/ContentCollection.feature | 2 +- .../Tests/Behavior/Features/Fusion/FlowQuery.feature | 2 +- .../Tests/Behavior/Features/Fusion/Menu.feature | 2 +- .../Resources/Private/Templates/Workspace/Show.html | 6 +++--- 8 files changed, 11 insertions(+), 23 deletions(-) diff --git a/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php b/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php index 6e685d56e5c..009de383a16 100644 --- a/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php +++ b/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php @@ -79,17 +79,6 @@ */ public ContentSubgraphIdentity $subgraphIdentity; - /** - * In PHP please use {@see $aggregateId} instead. - * - * For Fusion please use the upcoming FlowQuery operation: - * ``` - * ${q(node).id()} - * ``` - * @deprecated will be removed before the final 9.0 release - */ - public NodeAggregateId $nodeAggregateId; - /** * In PHP please use {@see $name} instead. * @@ -134,7 +123,6 @@ private function __construct( throw new \InvalidArgumentException('The NodeName must be set if the Node is tethered.', 1695118377); } // legacy to be removed before Neos9 - $this->nodeAggregateId = $this->aggregateId; $this->nodeName = $this->name; $this->subgraphIdentity = ContentSubgraphIdentity::create( $contentRepositoryId, diff --git a/Neos.Neos/Classes/Domain/Repository/SiteRepository.php b/Neos.Neos/Classes/Domain/Repository/SiteRepository.php index a70dc5074e4..6146a3acfa2 100644 --- a/Neos.Neos/Classes/Domain/Repository/SiteRepository.php +++ b/Neos.Neos/Classes/Domain/Repository/SiteRepository.php @@ -110,7 +110,7 @@ public function findOneByNodeName(string|SiteNodeName $nodeName): ?Site * To find the correct site node by its descended child node leverage `findClosestNode`: * ```php * $siteNode = $subgraph->findClosestNode( - * $node->nodeAggregateId, + * $node->aggregateId, * FindClosestNodeFilter::create(nodeTypes: NodeTypeNameFactory::NAME_SITE) * ); * ``` diff --git a/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html b/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html index 7f112b3b14a..04380e2fb73 100644 --- a/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html +++ b/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html @@ -26,9 +26,9 @@