From 71abbee8dcc66537e9e1418ae7095f5f888abffb Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sun, 30 Jun 2024 10:15:23 +0200 Subject: [PATCH 1/7] TASK: Remove b/c layer `Node::$nodeAggregateId` --- .../Classes/Projection/ContentGraph/Node.php | 12 ------------ .../Classes/Domain/Repository/SiteRepository.php | 2 +- .../Private/Templates/Service/Nodes/Index.html | 4 ++-- .../Private/Templates/Service/Nodes/Show.html | 4 ++-- .../Features/Fusion/ContentCollection.feature | 2 +- .../Tests/Behavior/Features/Fusion/FlowQuery.feature | 2 +- .../Tests/Behavior/Features/Fusion/Menu.feature | 2 +- .../Resources/Private/Templates/Workspace/Show.html | 6 +++--- 8 files changed, 11 insertions(+), 23 deletions(-) diff --git a/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php b/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php index 6e685d56e5c..009de383a16 100644 --- a/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php +++ b/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php @@ -79,17 +79,6 @@ */ public ContentSubgraphIdentity $subgraphIdentity; - /** - * In PHP please use {@see $aggregateId} instead. - * - * For Fusion please use the upcoming FlowQuery operation: - * ``` - * ${q(node).id()} - * ``` - * @deprecated will be removed before the final 9.0 release - */ - public NodeAggregateId $nodeAggregateId; - /** * In PHP please use {@see $name} instead. * @@ -134,7 +123,6 @@ private function __construct( throw new \InvalidArgumentException('The NodeName must be set if the Node is tethered.', 1695118377); } // legacy to be removed before Neos9 - $this->nodeAggregateId = $this->aggregateId; $this->nodeName = $this->name; $this->subgraphIdentity = ContentSubgraphIdentity::create( $contentRepositoryId, diff --git a/Neos.Neos/Classes/Domain/Repository/SiteRepository.php b/Neos.Neos/Classes/Domain/Repository/SiteRepository.php index a70dc5074e4..6146a3acfa2 100644 --- a/Neos.Neos/Classes/Domain/Repository/SiteRepository.php +++ b/Neos.Neos/Classes/Domain/Repository/SiteRepository.php @@ -110,7 +110,7 @@ public function findOneByNodeName(string|SiteNodeName $nodeName): ?Site * To find the correct site node by its descended child node leverage `findClosestNode`: * ```php * $siteNode = $subgraph->findClosestNode( - * $node->nodeAggregateId, + * $node->aggregateId, * FindClosestNodeFilter::create(nodeTypes: NodeTypeNameFactory::NAME_SITE) * ); * ``` diff --git a/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html b/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html index 7f112b3b14a..04380e2fb73 100644 --- a/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html +++ b/Neos.Neos/Resources/Private/Templates/Service/Nodes/Index.html @@ -26,9 +26,9 @@

{neos:backend.translate(id: 'service.nodes.title', value: 'Nodes')}

- ({node.nodeAggregateId.value}) + ({node.aggregateId.value}) [{node.nodeTypeName.value}] - {neos:backend.translate(id: 'service.nodes.show', value: 'Show')} + {neos:backend.translate(id: 'service.nodes.show', value: 'Show')} diff --git a/Neos.Neos/Resources/Private/Templates/Service/Nodes/Show.html b/Neos.Neos/Resources/Private/Templates/Service/Nodes/Show.html index 7c1f2816b76..0d3490174c1 100644 --- a/Neos.Neos/Resources/Private/Templates/Service/Nodes/Show.html +++ b/Neos.Neos/Resources/Private/Templates/Service/Nodes/Show.html @@ -13,7 +13,7 @@

{neos:backend.translate(id: 'node', value: 'Node')}: {node.label}

{neos:backend.translate(id: 'service.nodes.nodeProperties', value: 'Node Properties')} _identifier - {node.nodeAggregateId.value} + {node.aggregateId.value} _path @@ -48,7 +48,7 @@

{neos:backend.translate(id: 'node', value: 'Node')}: {node.label}

- {neos:backend.translate(id: 'service.nodes.show', value: 'Show')} + {neos:backend.translate(id: 'service.nodes.show', value: 'Show')} diff --git a/Neos.Neos/Tests/Behavior/Features/Fusion/ContentCollection.feature b/Neos.Neos/Tests/Behavior/Features/Fusion/ContentCollection.feature index 643ba787c6c..f2cf6d5d7ed 100644 --- a/Neos.Neos/Tests/Behavior/Features/Fusion/ContentCollection.feature +++ b/Neos.Neos/Tests/Behavior/Features/Fusion/ContentCollection.feature @@ -127,7 +127,7 @@ Feature: Tests for the "Neos.Neos:ContentCollection" Fusion prototype include: resource://Neos.Neos/Private/Fusion/Root.fusion prototype(Neos.Neos:Test.ContentType) < prototype(Neos.Fusion:Value) { - value = ${node.nodeAggregateId.value + ' (' + node.nodeTypeName.value + ') '} + value = ${q(node).id() + ' (' + node.nodeTypeName.value + ') '} } test = Neos.Neos:ContentCollection { diff --git a/Neos.Neos/Tests/Behavior/Features/Fusion/FlowQuery.feature b/Neos.Neos/Tests/Behavior/Features/Fusion/FlowQuery.feature index bd76b9e096c..4d4adec15dd 100644 --- a/Neos.Neos/Tests/Behavior/Features/Fusion/FlowQuery.feature +++ b/Neos.Neos/Tests/Behavior/Features/Fusion/FlowQuery.feature @@ -95,7 +95,7 @@ Feature: Tests for the "Neos.ContentRepository" Flow Query methods. renderer = Neos.Fusion:Loop { items = ${props.nodes} itemName = 'node' - itemRenderer = ${node.nodeAggregateId.value} + itemRenderer = ${q(node).id()} @glue = ',' } } diff --git a/Neos.Neos/Tests/Behavior/Features/Fusion/Menu.feature b/Neos.Neos/Tests/Behavior/Features/Fusion/Menu.feature index 895450837c1..5e87ba4b4fa 100644 --- a/Neos.Neos/Tests/Behavior/Features/Fusion/Menu.feature +++ b/Neos.Neos/Tests/Behavior/Features/Fusion/Menu.feature @@ -101,7 +101,7 @@ Feature: Tests for the "Neos.Neos:Menu" and related Fusion prototypes renderer = Neos.Fusion:Loop { items = ${props.items} itemRenderer = afx` - {item.node.nodeAggregateId.value} ({item.menuLevel}){String.chr(10)} + {q(item.node).id()} ({item.menuLevel}){String.chr(10)} ` } diff --git a/Neos.Workspace.Ui/Resources/Private/Templates/Workspace/Show.html b/Neos.Workspace.Ui/Resources/Private/Templates/Workspace/Show.html index 3ce35967d43..5ae008b0a30 100644 --- a/Neos.Workspace.Ui/Resources/Private/Templates/Workspace/Show.html +++ b/Neos.Workspace.Ui/Resources/Private/Templates/Workspace/Show.html @@ -32,7 +32,7 @@ - + @@ -56,11 +56,11 @@ - + - + From 3518a343101a713cf5c804a3e6bf8ee7e0c0e6c5 Mon Sep 17 00:00:00 2001 From: mhsdesign <85400359+mhsdesign@users.noreply.github.com> Date: Sun, 30 Jun 2024 10:20:43 +0200 Subject: [PATCH 2/7] TASK: Remove b/c layer `Node::$nodeName` --- .../Classes/Projection/ContentGraph/Node.php | 12 ------------ .../Private/Fusion/Backend/Views/Login.fusion | 4 ++-- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php b/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php index 009de383a16..22a63ea4539 100644 --- a/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php +++ b/Neos.ContentRepository.Core/Classes/Projection/ContentGraph/Node.php @@ -79,17 +79,6 @@ */ public ContentSubgraphIdentity $subgraphIdentity; - /** - * In PHP please use {@see $name} instead. - * - * For Fusion use: - * ``` - * ${node.name.value} - * ``` - * @deprecated will be removed before the final 9.0 release - */ - public ?NodeName $nodeName; - /** * @param ContentRepositoryId $contentRepositoryId The content-repository this Node belongs to * @param WorkspaceName $workspaceName The workspace of this Node @@ -123,7 +112,6 @@ private function __construct( throw new \InvalidArgumentException('The NodeName must be set if the Node is tethered.', 1695118377); } // legacy to be removed before Neos9 - $this->nodeName = $this->name; $this->subgraphIdentity = ContentSubgraphIdentity::create( $contentRepositoryId, $contentStreamId, diff --git a/Neos.Neos/Resources/Private/Fusion/Backend/Views/Login.fusion b/Neos.Neos/Resources/Private/Fusion/Backend/Views/Login.fusion index eee0c1623e7..0611dfdbe24 100644 --- a/Neos.Neos/Resources/Private/Fusion/Backend/Views/Login.fusion +++ b/Neos.Neos/Resources/Private/Fusion/Backend/Views/Login.fusion @@ -26,7 +26,7 @@ prototype(Neos.Neos:View.Login) < prototype(Neos.Fusion:Component) { } renderer = afx` - +