Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove deprecated beta10 apis #5168

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jun 30, 2024

Resolves: #5043

  • Remove b/c layer CommandResult::block()
  • Remove b/c layer Node::$nodeName
  • Remove b/c layer Node::$nodeAggregateId
  • Remove b/c layer Node::getLabel()
  • Remove b/c layer Node::$subgraphIdentity
  • Remove NodeAggregate::$contentStreamId
  • The b/c layer Node::$nodeType was already removed previously via !!! TASK: Remove Node::nodeType #5021

Upgrade instructions

See release notes of Beta10: https://discuss.neos.io/t/neos-9-beta-10-release/6578

Review instructions

The last usage of $node->subgraphIdentity->contentStreamId in the CI will be removed here #5169 and will turn the tests green.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign self-assigned this Jun 30, 2024
@mhsdesign mhsdesign force-pushed the task/removeDeprecatedBeta10Apis branch from b7b7599 to 865fe51 Compare July 3, 2024 08:05
@mhsdesign mhsdesign requested review from ahaeslich, bwaidelich, kitsunet and pKallert and removed request for ahaeslich July 3, 2024 08:05
@mhsdesign
Copy link
Member Author

The CI will be made green via #5169 (could probably be merged first)

Copy link
Contributor

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got nothin' but nitpicks :) And aside from the remaining linting issue, that's a 👍 from me.

I also did an E2E UI test run locally and it looks 👌

@@ -46,7 +46,7 @@ prototype(Neos.Neos:View.Login) < prototype(Neos.Fusion:Component) {
</figure>

<h1 class="neos-login-heading">
{I18n.id('login.index.title').value('Login to').package('Neos.Neos').source('Main')} <strong>{site.name}</strong>
{I18n.id('login.index.title').value('Login to').package('Neos.Neos').source('Main')} <strong>{props.site.name.value}</strong>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mhsdesign mhsdesign force-pushed the task/removeDeprecatedBeta10Apis branch from 865fe51 to 9120075 Compare July 13, 2024 09:06
@mhsdesign mhsdesign force-pushed the task/removeDeprecatedBeta10Apis branch from 9120075 to 32c2a26 Compare July 26, 2024 10:37
@nezaniel nezaniel self-requested a review July 29, 2024 10:42
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green again (thx @kitsunet), this looks very mergeable to me

@nezaniel nezaniel merged commit 3b50b6e into neos:9.0 Jul 29, 2024
9 checks passed
@kitsunet
Copy link
Member

Nod yeah post merge 👍

@mhsdesign mhsdesign deleted the task/removeDeprecatedBeta10Apis branch July 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove $node->subgraphIdentity->contentStreamId
4 participants