Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow static resources for og:image #131

Open
Nikdro opened this issue Jun 21, 2019 · 2 comments
Open

Allow static resources for og:image #131

Nikdro opened this issue Jun 21, 2019 · 2 comments
Labels
Hacktoberfest

Comments

@Nikdro
Copy link
Contributor

Nikdro commented Jun 21, 2019

In some projects, we use a fallback-image from Resources/Public for og:image, if no OpenGraphImage is defined in inspector.

Since 3.0 this isn't so easy with Neos.Seo:OpenGraphMetaTags. It assumes, that image is always an asset (i.e. persisted resource). It would be nice to be able to use resource://Vendor.Package/[...] URLS in the Neos.Fusion:Case for image.
@Sebobo
Copy link
Member

Sebobo commented Jun 21, 2019

Hm, basically we could extend the ImageHelper to accept AssetInterfaces AND resource paths.
This way, all the benefits of the auto crop etc. would apply.

Would you like to try to make this change?

@Nikdro
Copy link
Contributor Author

Nikdro commented Jun 27, 2019 •
edited
Loading

Sounds good. Will do 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sebobo @Nikdro