Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Hreflang shows non translated values #193

Open
1 task done
paavo opened this issue Dec 23, 2024 · 0 comments
Open
1 task done

BUG: Hreflang shows non translated values #193

paavo opened this issue Dec 23, 2024 · 0 comments

Comments

@paavo
Copy link
Contributor

paavo commented Dec 23, 2024

This is a:

  • bug

  • Version: "3.3.5"

What you did

I have a site with a fallback language dimension.
Language FR shows DE if no content is available.

Expected Behavior

Non translated Documents should not be listed as hreflang like:

<link href="https://domain.tld/path/to/german-content" rel="canonical">
<link href="https://domain.tld/path/to/german-content" hreflang="x-default" rel="alternate">
<link href="https://domain.tld/path/to/german-content" hreflang="de" rel="alternate">

Actual Behavior

Fallback Documents get listed as alternate, but link to the fallback-uri:

<link href="https://domain.tld/path/to/german-content" rel="canonical">
<link href="https://domain.tld/path/to/german-content" hreflang="x-default" rel="alternate">
<link href="https://domain.tld/path/to/german-content" hreflang="de" rel="alternate">
<link href="https://domain.tld/path/to/german-content" hreflang="fr" rel="alternate">

Last line should not be shown


Looks like item.state is not 'absent' when its a Fallback @jonnitto 🤔
ddeee4a


Language Fallback

  ContentRepository:
    contentDimensions:
      language:
        label: 'Sprachen'
        icon: icon-language
        default: de
        defaultPreset: de
        presets:
          #all: ~
          de:
            label: DE
            values:
              - de
            uriSegment: ''
          fr:
            label: FR
            values:
              - fr
              - de
            uriSegment: fr
          ...  
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant