Support XDG_DATA_HOME #168
Conversation
|
I wouldn't expect us to dump Nerves hub files into the root of |
|
Ooo. Right. I need to make a subdir |
jjcarstens
force-pushed
the
data-home
branch
2 times, most recently
from
f1b23de to
035a308
Compare
|
Fixed. Its following the pattern of Nerves a bit. We can be more aggressive in following XDG standard here if we want as to not default |
jjcarstens
force-pushed
the
data-home
branch
from
035a308 to
e18650f
Compare
|
I think that Nerves suffers from XDG_DATA_HOME apathy: we know it's the right thing to do, but no one cares enough to change it, and it is a breaking change to people who have XDG_DATA_HOME defined. I almost wonder if we've painted ourselves into a corner and if someone already has a |
Resolves #120
jjcarstens
force-pushed
the
data-home
branch
from
e18650f to
cbe4515
Compare
|
Okay, I think I like how this is working. Application and env var get precedence. If it comes to the default and The only other thing to consider is if we want to travers |
| def home_dir() do | ||
| from_config = Application.get_env(:nerves_hub_cli, :home_dir) | ||
| from_env = System.get_env("NERVES_HUB_HOME") | ||
| xdg_home_nh = :filename.basedir(:user_data, "nerves-hub", %{os: :linux}) |
There was a problem hiding this comment.
| xdg_home_nh = :filename.basedir(:user_data, "nerves-hub", %{os: :linux}) | |
| xdg_home_nh = :filename.basedir(:user_data, "nerves-hub") |
It seems like we should trust whatever basedir tells us that we should use for storing data so that this does the right thing on OSX. I "think" that renaming the variables to remove the XDG and updating the error text to refer to this as the user data directory below is what's needed to make this generic.
I.e., the same logic can still be used:
- Use
Application.get_env(:nerves_hub_cli, :home_dir) - Use
$NERVES_HUB_HOME - If
~/.nerves-huband not the:user_datalocation, tell the user to move the directory - Use the
:user_datalocation
Resolves #120