Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom retry config #32

Closed
jeanparpaillon opened this issue Mar 2, 2023 · 0 comments · Fixed by #33
Closed

Allow custom retry config #32

jeanparpaillon opened this issue Mar 2, 2023 · 0 comments · Fixed by #33

Comments

@jeanparpaillon
Copy link

Downloader's retry config should be customizable.

I suggest we use the following application env:

config :nerves_hub_link_common, :retry_config, [...]

This env could be merged with default settings for creating initial %RetryConfig{} structure

jeanparpaillon pushed a commit to jeanparpaillon/nerves_hub_link_common that referenced this issue Mar 2, 2023
When starting downloader without RetryConfig argument, retry config is
built by merging `:retry_config` application env with defaults.

For instance, default `max_disconnects` could be overriden with:
```
config :nerves_hub_link_common, :retry_config, max_disconnects: 20
```

Closes nerves-hub#32
fhunleth pushed a commit that referenced this issue Mar 3, 2023
When starting downloader without RetryConfig argument, retry config is
built by merging `:retry_config` application env with defaults.

For instance, default `max_disconnects` could be overriden with:
```
config :nerves_hub_link_common, :retry_config, max_disconnects: 20
```

Closes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant