Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom retry config #33

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Allow custom retry config #33

merged 1 commit into from
Mar 3, 2023

Conversation

jeanparpaillon
Copy link

When starting downloader without RetryConfig argument, retry config is built by merging :retry_config application env with defaults.

For instance, default max_disconnects could be overriden with:

config :nerves_hub_link_common, :retry_config, max_disconnects: 20

Closes #32

Allow custom retry config
98ba8d2 
When starting downloader without RetryConfig argument, retry config is
built by merging `:retry_config` application env with defaults.

For instance, default `max_disconnects` could be overriden with:
```
config :nerves_hub_link_common, :retry_config, max_disconnects: 20
```

Closes nerves-hub#32
@fhunleth fhunleth requested a review from jjcarstens March 3, 2023 12:42
@fhunleth fhunleth merged commit acfcffb into nerves-hub:main Mar 3, 2023
@fhunleth
Copy link
Contributor

fhunleth commented Mar 3, 2023

Thanks!

@jeanparpaillon jeanparpaillon deleted the 32-custom-retry-config branch March 3, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhunleth fhunleth fhunleth approved these changes

@jjcarstens jjcarstens Awaiting requested review from jjcarstens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom retry config
2 participants
@jeanparpaillon @fhunleth