Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure DNS servers #34

Open
mattludwigs opened this issue Mar 5, 2020 · 0 comments
Open

Configure DNS servers #34

mattludwigs opened this issue Mar 5, 2020 · 0 comments

Comments

@mattludwigs
Copy link
Contributor

Some providers will provide DNS servers, so we don't have to ask for them.

  • Add configuration field :dns_servers which is a list of DNS IP address
  • If this field is configured
    • Don't have usepeerdns option in the pppd options
    • Setup the VintageNet.NameResolver to use the provided IP(s)
    • Note: Right now in the PPPDNotifications module we assume that we always ask
      for DNS servers from the peer, we will need to not make this assumption and check those values before trying to set up the VintageNet.NameResolver
  • If the field is not configured everything should function as it does right now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant