From 632a0e9c1543e2e7b55a9d51497b468514a8e6ca Mon Sep 17 00:00:00 2001 From: Daniel Tschinder <231804+danez@users.noreply.github.com> Date: Fri, 18 Nov 2022 14:30:04 +0100 Subject: [PATCH] fix: Bump Go to 1.19 (#870) * fix: Bump Go to 1.19 * chore: use 1.19.x --- Dockerfile | 2 +- included_software.md | 2 +- run-build.sh | 2 +- tests/go/base.bats | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Dockerfile b/Dockerfile index 0fb267d1..8d841863 100644 --- a/Dockerfile +++ b/Dockerfile @@ -458,7 +458,7 @@ ENV PATH "$PATH:/opt/buildhome/.gimme/bin" ENV GOPATH "/opt/buildhome/.gimme_cache/gopath" ENV GOCACHE "/opt/buildhome/.gimme_cache/gocache" # Install the default version -ENV GIMME_GO_VERSION "1.17.x" +ENV GIMME_GO_VERSION "1.19.x" ENV GIMME_ENV_PREFIX "/opt/buildhome/.gimme/env" RUN gimme | bash diff --git a/included_software.md b/included_software.md index 26a589c0..74d8ec3f 100644 --- a/included_software.md +++ b/included_software.md @@ -22,7 +22,7 @@ The specific patch versions included will depend on when the image was last buil * 7.4 * 8.0 (default) * Go - `GO_VERSION` - * 1.17 (default) + * latest 1.19.x (default) * Any version available on the [Go downloads page](https://golang.org/dl/) * Java * 8 (default) diff --git a/run-build.sh b/run-build.sh index cdf9e909..dc3f842f 100755 --- a/run-build.sh +++ b/run-build.sh @@ -33,7 +33,7 @@ cd "$NETLIFY_REPO_DIR/$NETLIFY_PACKAGE_DIR" || exit : "${RUBY_VERSION="2.7.2"}" : "${YARN_VERSION="1.22.19"}" : "${PNPM_VERSION="7.13.4"}" -: "${GO_VERSION="1.17"}" +: "${GO_VERSION="1.19.x"}" : "${PYTHON_VERSION="3.8"}" : "${BUILD_INFO="$defaultBuildInfo"}" : "${FEATURE_FLAGS="build-image_use_new_package_manager_detection"}" diff --git a/tests/go/base.bats b/tests/go/base.bats index e6eabe5f..3a0f8b7a 100644 --- a/tests/go/base.bats +++ b/tests/go/base.bats @@ -11,12 +11,12 @@ setup() { load '../../run-build-functions.sh' } -@test 'go version 1.17 at the latest patch is installed and available at startup by default' { +@test 'go version 1.19 at the latest patch is installed and available at startup by default' { run install_go assert_success # we can't specify which patch version because it will change - assert_output --partial "Installing Go version 1.17." - assert_output --partial "go version go1.17." + assert_output --partial "Installing Go version 1.19." + assert_output --partial "go version go1.19." } @test 'install custom go version' {