Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional searching capabilities to orders api #138

Open
RoseannaM opened this issue Oct 17, 2018 · 4 comments
Open

Add additional searching capabilities to orders api #138

RoseannaM opened this issue Oct 17, 2018 · 4 comments
Assignees

Comments

@RoseannaM
Copy link

- Do you want to request a feature or report a bug?
Feature

- What is the current behavior?
We can currently search orders by item and email

- What is the expected behavior?
To search all order fields:

  • ID
  • Date
  • Type
  • Subtotal
  • Taxes
  • Total
  • Customer name
  • Billing status
  • Billing address
  • Billing country
  • Billing company
  • VAT ID
  • Shipping status
  • Shipping address
  • Shipping country
  • Shipping company

image

@mraerino
Copy link
Contributor

In which ways does this issue differ from #137? (How do we distinguish filtering from searching?)

We should probably merge the filtering and searching stuff into one issue to make sure all the fields we need can be filtered, right?

This issue does not say anything about searching multiple fields at the same time, so that's out of the scope?

@RoseannaM
Copy link
Author

As a user I would expect search to perform full text search on the entire record.

This means if a user searched for "red blue black" any record that has any of those terms should be returned, and they should be sorted by number of search term hits.

@mraerino
Copy link
Contributor

I see. When talking with Bret I thought we agreed that the SQL database is unsuited for full record searches. Something like Algolia or ElasticSearch comes to mind in that case.

Also, why did you include Shipping status and Billing status in the list of fields? Is it desirable to be able to search for "shipped" and then get records based on their status? This should be a use case for the regular filtering capabilities, shouldn't it?

@bcomnes
Copy link
Contributor

bcomnes commented Oct 22, 2018

Since we really aught to go down the generalized search provider route at some point, we are going to hold off on this end of things until we research that some more. For now, I can selectively add fields as needed to the API. Down the road @mraerino can help us add a search provider api for algolia or elastic serach.

So... current status of this issue is that its on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants