Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nut-scanner should emit warning for bogus (all-zero) or duplicate serials #1810

Closed
jimklimov opened this issue Jan 13, 2023 · 1 comment · Fixed by #1811
Closed

nut-scanner should emit warning for bogus (all-zero) or duplicate serials #1810

jimklimov opened this issue Jan 13, 2023 · 1 comment · Fixed by #1811
Labels
enhancement nut-scanner USB-duplicate-devices Track bugs and issues about monitoring several devices that seem identical to NUT or libusb
Milestone
2.8.1

Comments

@jimklimov
Copy link
Member

Since this week, nut-scanner should generate more matching fields into config, including "bus" and "device" (port) number which most USB-aware drivers consult when searching for supported unique devices.

Good point about warning for bogus (all-zero) or duplicate serials though.

Originally posted by @jimklimov in #161 (comment)
@jimklimov jimklimov added enhancement nut-scanner USB-duplicate-devices Track bugs and issues about monitoring several devices that seem identical to NUT or libusb labels Jan 13, 2023
@jimklimov jimklimov added this to the 2.8.1 milestone Jan 13, 2023
@jimklimov jimklimov mentioned this issue Jan 14, 2023
Merged
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 14, 2023
@jimklimov
nut-scanner: report bogus and duplicate serial numbers [networkupstoo…
0c92764 
…ls#1810]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 14, 2023
@jimklimov
tools/nut-scanner/nutscan-display.c: trace entry into the display met…
040df4d 
…hods [networkupstools#1810]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 14, 2023
@jimklimov
tools/nut-scanner/nutscan-display.c: nutscan_display_sanity_check_ser…
a40db65 
…ial(): trace progress through logic [networkupstools#1810]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 14, 2023
@jimklimov
tools/nut-scanner/nutscan-display.c: nutscan_display_sanity_check_ser…
fb1856d 
…ial(): if not null, one device entry exists [networkupstools#1810]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 14, 2023
@jimklimov
tools/nut-scanner/nutscan-display.c: nutscan_display_sanity_check_ser…
7304fc5 
…ial(): fix failsafe condition [networkupstools#1810]
jimklimov added a commit to jimklimov/nut that referenced this issue Jan 14, 2023
@jimklimov
tools/nut-scanner/nutscan-display.c: weave nutdevX numbering for diff…
10e0d0b 
…erent scan types when generating ups.conf with sanity-check warnings with a global var [networkupstools#1810]
@jimklimov jimklimov mentioned this issue Jan 15, 2023
Open
@jimklimov
Copy link
Member Author

jimklimov commented Jan 15, 2023 •
edited
Loading

UPDATE: PR #1811 currently addresses sanity-checking for one media type (e.g. SNMP and USB separately), not across multiple discoveries (follow-up in #1813)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement nut-scanner USB-duplicate-devices Track bugs and issues about monitoring several devices that seem identical to NUT or libusb
Projects
None yet
Milestone
2.8.1
Development

Successfully merging a pull request may close this issue.

nut-scanner: report bogus and duplicate serial numbers jimklimov/nut
1 participant
@jimklimov