Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ups.conf toggle for voltage multipliers #2031

Open
jimklimov opened this issue Aug 31, 2023 · 0 comments
Open

Add an ups.conf toggle for voltage multipliers #2031

jimklimov opened this issue Aug 31, 2023 · 0 comments
Labels
enhancement Incorrect or missing readings On some devices driver-reported values are systemically off (e.g. x10, x0.1, const+Value, etc.) Low-hanging fruit A proposal or issue that is good for newcomers to codebase or otherwise a quick win
Milestone

Comments

@jimklimov
Copy link
Member

jimklimov commented Aug 31, 2023

battery.voltage: 1.3
battery.voltage.nominal: 1.2
is this a bug? I thought that voltage should be a bit higher.

The original post by @gyulaasztalos in #616 (comment) experimented with neutering of divide_by_10_conversion() and legrand_times10M_info() in the mapping tables.

This issue is about adding a configuration toggle (and perhaps ways of guessing a default if not specified - e.g. based on some mapping of device/model/firmware... identifiers) to report original voltages or factor them. Seems to be a common problem for many vendors, and sometimes for same brand/model devices with different HW/FW releases...

Note that currently not many drivers (or mapping tables where used) suggest having such a multiplication/division at all. For those that do, if we guess a default value - log this, with a suggestion to use the toggle if numbers seem off the target.

Loosely related to #1279 / #1652 area as well.

@jimklimov jimklimov added enhancement Incorrect or missing readings On some devices driver-reported values are systemically off (e.g. x10, x0.1, const+Value, etc.) Low-hanging fruit A proposal or issue that is good for newcomers to codebase or otherwise a quick win labels Aug 31, 2023
@jimklimov jimklimov added this to the 2.8.2 milestone Aug 31, 2023
@jimklimov jimklimov modified the milestones: 2.8.2, 2.8.3 Apr 6, 2024
@jimklimov jimklimov modified the milestones: 2.8.3, 2.8.4 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Incorrect or missing readings On some devices driver-reported values are systemically off (e.g. x10, x0.1, const+Value, etc.) Low-hanging fruit A proposal or issue that is good for newcomers to codebase or otherwise a quick win
Projects
None yet
Development

No branches or pull requests

1 participant