Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy:repair doesn't utilize custom health check method #179

Open
intjonathan opened this issue Feb 17, 2017 · 1 comment
Open

deploy:repair doesn't utilize custom health check method #179

intjonathan opened this issue Feb 17, 2017 · 1 comment

Comments

@intjonathan
Copy link
Contributor

The deploy:repair task is not only undocumented, but uses a naive invocation of #http_status_ok?:

unless method(:http_status_ok?).call(server, port, fetch(:status_endpoint, '/'))

Users with custom health checks can't avail themselves of this useful task.
@relistan
Copy link
Collaborator

😞 Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@relistan @intjonathan