Speed up BackoffSampler with counters #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@binaryseed Looks like one failure on 1.15/OTP-26 🤔 |
binaryseed
force-pushed
the
vince/backoff-sampler-faster
branch
from
57f9726 to
89b948a
Compare
|
Fluke perhaps, it's green now |
binaryseed
force-pushed
the
vince/backoff-sampler-faster
branch
from
38de12c to
e8ec0af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up the
BackoffSamplerby storing its state in:countersinstead of aGenServer. This means it's no longer a process message queue bottleneck.Kept the implementation functions the same shape so that the logic is unchanged.
Closes #385