Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NcAppContent] list is rebuild every time when details were shown with no-split or mobile view #6204

Open
wofferl opened this issue Nov 10, 2024 · 3 comments · May be fixed by #6261
Open

[NcAppContent] list is rebuild every time when details were shown with no-split or mobile view #6204

wofferl opened this issue Nov 10, 2024 · 3 comments · May be fixed by #6261

Comments

@wofferl
Copy link
Contributor

wofferl commented Nov 10, 2024

<div v-if="isMobile || layout === 'no-split'"
class="app-content-wrapper app-content-wrapper--no-split"
:class="{
'app-content-wrapper--show-details': showDetails,
'app-content-wrapper--show-list': !showDetails,
'app-content-wrapper--mobile': isMobile,}">
<NcAppDetailsToggle v-if="showDetails" @click.native.stop.prevent="hideDetails" />
<slot v-if="!showDetails" name="list" />
<slot v-else />
</div>

Is this change in 8.10.0 (6f74155) intentional, to remove the list from dom every time the details are shown?

@susnux
Copy link
Contributor

susnux commented Nov 11, 2024

cc @GretaD

@GretaD
Copy link
Contributor

GretaD commented Nov 12, 2024

Hello, this is "intended" by implementation. But we understand concerns raised in this ticket. I'm unsure how to proceed. I'll loop @ShGKme so we can discuss this soon if we can approach this differently.

@wofferl
Copy link
Contributor Author

wofferl commented Nov 13, 2024

Wouldn't v-show for the list be the right approach here or are there technical reasons for removing the list?

                                <slot v-show="!showDetails" name="list" />

                                <slot v-if="showDetails" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants