mastercontainer: update to php8.4 #5970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/5699/update-to-8.4
branch
from
9e56ee6 to
7d5a35e
Compare
29 tasks
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/5699/update-to-8.4
branch
from
fd1ef62 to
c028e91
Compare
Signed-off-by: GitHub <[email protected]> Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/5699/update-to-8.4
branch
from
c028e91 to
ee0e2ac
Compare
szaimen
added
3. to review
|
@docjyJ please review if possible :) |
come-nc
reviewed
Jan 28, 2025
come-nc
reviewed
Jan 28, 2025
| return $communityContainersDirectory; | ||
| } | ||
|
|
||
| return $newCommunityContainersDirectory; |
There was a problem hiding this comment.
Same code three time, could use a common method
private static function GetDirectoryWithBackUp(string $path, string $relativeBackupPath): string
|
Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/5699/update-to-8.4
branch
from
f9a0f5c to
92d6749
Compare
24 tasks
come-nc
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5699
The baseline was updated and will be decrease to 0 again in #5974