Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrx/store: Update examples to standalone APIs #4067

Open
2 tasks
brandonroberts opened this issue Oct 16, 2023 · 13 comments
Open
2 tasks

@ngrx/store: Update examples to standalone APIs #4067

brandonroberts opened this issue Oct 16, 2023 · 13 comments

Comments

@brandonroberts
Copy link
Member

brandonroberts commented Oct 16, 2023

Information

Standalone APIs have been stable since Angular v16, and we should update the @ngrx/store documentation to use standalone APIs by default, and reference previous versions of the docs for module-based apps.

Documentation page

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@Jad31
Copy link

Jad31 commented Oct 18, 2023

Can we make PRs to help on this issue?

@brandonroberts
Copy link
Member Author

@Jad31 sure. I'll take Store/Effects but the rest are up for grabs

@Jad31
Copy link

Jad31 commented Oct 30, 2023

@brandonroberts I'm eager to start working on the other sections. However, I'd appreciate it if you could share an example or template for the "Store/Effects" part first. This will help ensure a consistent approach across all sections. Thanks!

@KirilZafirov
Copy link

I will pick up Router Store!

@brandonroberts
Copy link
Member Author

Thanks everyone! I will have an example PR soon

@aboudard
Copy link

aboudard commented Jan 3, 2024

Hello ! I guess it's related to both docs and schematics, but is it planned to make / document a schematic option for basic operations in a standalone app in order not to use the StoreModule but the provideStore ?

@geromegrignon
Copy link
Contributor

Hi @brandonroberts, do you need extra support on it?
We have people confused trying to use NgRX as Angular is using Standalone APi by default now.

@rainerhahnekamp
Copy link
Contributor

#4417

@markostanimirovic markostanimirovic changed the title Docs: Update examples to standalone APIs @ngrx/store: Update examples to standalone APIs Jul 30, 2024
@markostanimirovic
Copy link
Member

This issue is now dedicated to updating @ngrx/store examples to standalone APIs.

Issues for other packages: #4468 (effects) #4469 (router-store) #4470 (store-devtools)

If anyone is interested in contributing, all mentioned issues are accepting PRs.

@Davidihl
Copy link

@geromegrignon since you offered support, I am mentioning you as I am considering to provide an update to the store walkthrough.

I identified these tasks:

  • Update example app
  • Update the description in walkthrough.md

While I am confident that I can update the walkthrough.md on my own, does updating the example app imply retesting/fixing all other examples since they share one package.json if I want to use e.g. angular 18/19? Or do you have an overview of someone is already working on updating the boilerplate?

Best regards

@geromegrignon
Copy link
Contributor

geromegrignon commented Dec 12, 2024

Hi @Davidihl, I miseed the previous accepting PRs tag so I still have to start working on it.
I need to check about these technicals details.

If you happen to attend NgGlühwein at Vienna, we can talk in person there!

@markostanimirovic
Copy link
Member

This issue includes updating code snippets and sections from @ngrx/store documentation:

1

Pages without examples with NgModules should not be modified.

This issue does not include updating the example-app project to standalone, there is a separate ticket for that: #4417

Here are the PRs for updating documentation of other packages to standalone:

@Davidihl
Copy link

@markostanimirovic thank you for clarifying.
@geromegrignon unfortunately I won't make it, my weekend is pretty stacked. I hope you will have a nice experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants