Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with "@glimmer/component": "^2.0.0" #1063

Open
johanrd opened this issue Dec 27, 2024 · 0 comments
Open

Not compatible with "@glimmer/component": "^2.0.0" #1063

johanrd opened this issue Dec 27, 2024 · 0 comments

Comments

@johanrd
Copy link
Contributor

johanrd commented Dec 27, 2024

Build an app with embroider, this addon + "@glimmer/component": "^2.0.0". See error:

Some V1 ember addons are resolving as incorrect peer dependencies. This makes it impossible for us to safely convert them to v2 format.

[email protected] -> [email protected] -> [email protected]
[email protected] -> [email protected] -> [email protected]
    sees peerDep @glimmer/[email protected]
      at app/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@glimmer/component
    but [email protected] is using @glimmer/[email protected]
      at app/node_modules/.pnpm/@[email protected]/node_modules/@glimmer/component

[email protected] -> [email protected] -> [email protected]
    sees peerDep @glimmer/[email protected]
      at app/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@glimmer/component
    but [email protected] is using @glimmer/[email protected]
      at app/node_modules/.pnpm/@[email protected]/node_modules/@glimmer/component

  👇 👇 👇
👉 See https://github.com/embroider-build/embroider/blob/main/docs/peer-dependency-resolution-issues.md for an explanation of the problem and suggestions for fixing it.
  👆 👆 👆

Not sure why this is happening, honestly, as both [email protected] and [email protected] have @glimmer/[email protected] in their peer deps.

See johanrd@0fc93b9 for possible fix

johanrd added a commit to johanrd/ember-mobile-menu that referenced this issue Dec 27, 2024
• widen peer range of @glimmer/component
• move @glimmer/component to peerDependency
johanrd added a commit to johanrd/ember-mobile-menu that referenced this issue Dec 27, 2024
• widen peer range of @glimmer/component
• move @glimmer/component to peerDependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant