Segfault, when assigning quote do to compileTime var NimNode #21222

yuanweixin · 2023-01-03T21:06:10Z

Description

Code

import std/macros
var x {.compileTime.} : NimNode = 
  quote do:
    echo "xxx"

The context is that I am trying to build up a compile-time list, containing data and NimNode (representing codeblocks), intended to be passed into a macro. But it seems directly assigning from quote do crashes the compiler (no compile error or warnings whatsoever).

Nim Version

Nim Compiler Version 1.6.8 [Linux: amd64]
Compiled at 2022-10-05
Copyright (c) 2006-2021 by Andreas Rumpf

git hash: c9f46ca
active boot switches: -d:release

Current Output

...........................................................SIGSEGV: Illegal storage access. (Attempt to read from nil?)
Segmentation fault

Expected Output

I expected this to compile. After all, I am using quote do in a compile-time context.

Possible Solution

No response

Additional Information

No response

The text was updated successfully, but these errors were encountered:

shirleyquirk · 2023-01-04T10:46:25Z

workaround (fix tbh, genast is a superior replacement for quote do):
use genast

import std/[macros,genasts]
var x{.compiletime.} : NimNode =
  genast():
    echo "xxx"

yuanweixin · 2023-01-04T15:13:48Z

thanks! was growing frustrated that I can't just quote things and pass them around. at least, this gets me past that segfault.

i suppose this is more of a user experience thing, but i find that putting genAst inside a tuple results in Error: named expression not allowed here, so have to resort to assigning the genAst to a var and then using that var in the tuple.

juancarlospaco · 2023-07-11T19:11:46Z

!nim c

import std/macros
var x {.compileTime.} : NimNode =
  quote do:
    echo "xxx"

github-actions · 2023-07-11T20:51:00Z

@juancarlospaco (contributor)

devel :-1: FAIL

Output

Error: Command failed: nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off  --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Stats

Created 2023-07-11T19:11:46Z
Started 2023-07-11T19:12:17
Finished 2023-07-11T19:12:18
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

IR

AST

nnkStmtList.newTree(
  nnkImportStmt.newTree(
    nnkInfix.newTree(
      newIdentNode("/"),
      newIdentNode("std"),
      newIdentNode("macros")
    )
  ),
  nnkVarSection.newTree(
    nnkIdentDefs.newTree(
      nnkPragmaExpr.newTree(
        newIdentNode("x"),
        nnkPragma.newTree(
          newIdentNode("compileTime")
        )
      ),
      newIdentNode("NimNode"),
      nnkCall.newTree(
        newIdentNode("quote"),
        nnkStmtList.newTree(
          nnkCommand.newTree(
            newIdentNode("echo"),
            newLit("xxx")
          )
        )
      )
    )
  )
)

stable :-1: FAIL

Output

Error: Command failed: nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off  --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Stats

Created 2023-07-11T19:11:46Z
Started 2023-07-11T19:12:18
Finished 2023-07-11T19:12:19
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

IR

AST

nnkStmtList.newTree(
  nnkImportStmt.newTree(
    nnkInfix.newTree(
      newIdentNode("/"),
      newIdentNode("std"),
      newIdentNode("macros")
    )
  ),
  nnkVarSection.newTree(
    nnkIdentDefs.newTree(
      nnkPragmaExpr.newTree(
        newIdentNode("x"),
        nnkPragma.newTree(
          newIdentNode("compileTime")
        )
      ),
      newIdentNode("NimNode"),
      nnkCall.newTree(
        newIdentNode("quote"),
        nnkStmtList.newTree(
          nnkCommand.newTree(
            newIdentNode("echo"),
            newLit("xxx")
          )
        )
      )
    )
  )
)

1.6.0 :-1: FAIL

Output

Error: Command failed: nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off  --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Stats

Created 2023-07-11T19:11:46Z
Started 2023-07-11T19:12:23
Finished 2023-07-11T19:12:23
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

IR

AST

nnkStmtList.newTree(
  nnkImportStmt.newTree(
    nnkInfix.newTree(
      newIdentNode("/"),
      newIdentNode("std"),
      newIdentNode("macros")
    )
  ),
  nnkVarSection.newTree(
    nnkIdentDefs.newTree(
      nnkPragmaExpr.newTree(
        newIdentNode("x"),
        nnkPragma.newTree(
          newIdentNode("compileTime")
        )
      ),
      newIdentNode("NimNode"),
      nnkCall.newTree(
        newIdentNode("quote"),
        nnkStmtList.newTree(
          nnkCommand.newTree(
            newIdentNode("echo"),
            newLit("xxx")
          )
        )
      )
    )
  )
)

1.4.0 :-1: FAIL

Output

Error: Command failed: nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off  --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Stats

Created 2023-07-11T19:11:46Z
Started 2023-07-11T19:12:27
Finished 2023-07-11T19:12:28
Duration now
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

IR

AST

nnkStmtList.newTree(
  nnkImportStmt.newTree(
    nnkInfix.newTree(
      newIdentNode("/"),
      newIdentNode("std"),
      newIdentNode("macros")
    )
  ),
  nnkVarSection.newTree(
    nnkIdentDefs.newTree(
      nnkPragmaExpr.newTree(
        newIdentNode("x"),
        nnkPragma.newTree(
          newIdentNode("compileTime")
        )
      ),
      newIdentNode("NimNode"),
      nnkCall.newTree(
        newIdentNode("quote"),
        nnkStmtList.newTree(
          nnkCommand.newTree(
            newIdentNode("echo"),
            newLit("xxx")
          )
        )
      )
    )
  )
)

1.2.0 :+1: OK

Output

Stats

Created 2023-07-11T19:11:46Z
Started 2023-07-11T19:12:43
Finished 2023-07-11T19:12:44
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

1.0.0 :+1: OK

Output

Stats

Created 2023-07-11T19:11:46Z
Started 2023-07-11T19:12:57
Finished 2023-07-11T19:12:58
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

0.20.2 :+1: OK

Output

Stats

Created 2023-07-11T19:11:46Z
Started 2023-07-11T19:13:08
Finished 2023-07-11T19:13:09
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

#2629d619a ➡️ 🐛

Diagnostics

Clyybber introduced a bug at 2020-07-29 16:17:20 +0200 on commit #2629d619a with message:

Fix forward declaration issues in template/macro context (#15091)

* Fix forward declaration issues in template/macro context

* Correct forward declaration resolving for overloads

* Remove old dead code

* WIP consistent gensym ids

* Minimize diff

* Remove obsoleted hack

* Add templInstCounter to give unique IDs to template instantiations

* Remove obsoleted code

* Eh, init in myOpen, not myProcess...

* Remove optNimV019

* Add testcase for #13484

The bug is in the files:

changelog.md
compiler/commands.nim
compiler/evaltempl.nim
compiler/lookups.nim
compiler/options.nim
compiler/procfind.nim
compiler/sem.nim
compiler/semdata.nim
compiler/semexprs.nim
compiler/semstmts.nim
compiler/semtempl.nim
compiler/types.nim
compiler/vm.nim
compiler/vmdef.nim
testament/important_packages.nim
tests/macros/tmacros_issues.nim
tests/template/tparams_gensymed.nim

The bug can be in the commits:

(Diagnostics sometimes off-by-one).

🤖 Bug found in 46 minutes bisecting 4387 commits at 95 commits per second.

ringabout · 2024-03-05T02:29:16Z

Similar case: #22282 (comment)

import std/macros

proc f(): NimNode =
  quote do:
    123

var a = static f()

Luyten-Orion · 2024-09-05T17:47:27Z

import std/macros
var myNode {.compileTime.} = newStmtList()
macro test(n: static NimNode) = discard
myNode.test()

This is enough to make the compiler segfault, too.

ringabout · 2025-01-23T13:32:35Z

related to #18367

ringabout added this to @ringabout's todos Jul 12, 2023

github-project-automation bot moved this to Maybe in @ringabout's todos Jul 12, 2023

ringabout mentioned this issue Mar 5, 2024

nim c -c SIGSEGV calling function with quasiquote-generated code #22282

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Segfault, when assigning quote do to compileTime var NimNode #21222

Segfault, when assigning quote do to compileTime var NimNode #21222

yuanweixin commented Jan 3, 2023

shirleyquirk commented Jan 4, 2023

yuanweixin commented Jan 4, 2023

juancarlospaco commented Jul 11, 2023

github-actions bot commented Jul 11, 2023

Output

Stats

IR

AST

Output

Stats

IR

AST

Output

Stats

IR

AST

Output

Stats

IR

AST

Output

Stats

Output

Stats

Output

Stats

Diagnostics

ringabout commented Mar 5, 2024

Luyten-Orion commented Sep 5, 2024

ringabout commented Jan 23, 2025

Segfault, when assigning quote do to compileTime var NimNode #21222

Segfault, when assigning quote do to compileTime var NimNode #21222

Comments

yuanweixin commented Jan 3, 2023

Description

Nim Version

Current Output

Expected Output

Possible Solution

Additional Information

shirleyquirk commented Jan 4, 2023

yuanweixin commented Jan 4, 2023

juancarlospaco commented Jul 11, 2023

github-actions bot commented Jul 11, 2023

Output

Stats

IR

AST

Output

Stats

IR

AST

Output

Stats

IR

AST

Output

Stats

IR

AST

Output

Stats

Output

Stats

Output

Stats

Diagnostics

ringabout commented Mar 5, 2024

Luyten-Orion commented Sep 5, 2024

ringabout commented Jan 23, 2025