-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BSD and platforms without official node.js binaries (with download = false) #178
Comments
I thought OpenBSD removed the Linux emulation. But while I wish we could support it, unless you're fetching someone else's builds that change will only mean that the Linux node will be downloaded and the build will fail. The Though with that said, if you |
Indeed, I am using dowload = false. But the error of unsupported OS still comes up. As you noted, In my setup, I have all of them already installed and working (using pkg_add binary package manager). So no downloads of node or npm tools are required.
|
Oooh that is a bug then, I don't the error should be appearing at all with My initial reason for starting to look into the code of this plugin was actually to get FreeBSD supported. |
thank you!. Just an FYI However, you will, likely, not be able to test this on netBSD -- because gradle does not work there, at all, with openjdk11 (works with jdk-8). There is an outstanding issue for that in netBSD tracker, but it had not been resolved yet. |
Previously we've accidentally depended on the isWindows check to see if we're on a supported platform or not, this had the unfortunate side-effect that even with `download = false` we triggered the error(). See #178
The implementation of this got a bit messy and there's a bunch of things that need to be fixed to do this properly, but I've started a WIP PR at #179 So on one hand, I think we can (in the future) support |
It seems that the only place were OpenBSD support would need to be added is at PlatformHelper.kt
If you would add
name.contains("openbsd") -> "linux"
And also (for completeness)
The text was updated successfully, but these errors were encountered: