You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried taking a stab at this and was able to successfully upgrade the repo to React 19 and everything seems to be working alright.
Issues I faced:
The latest version of storybook 8.4.7 threw tons of errors, so I tried their latest beta version, 8.5.0-beta.5, which made a few components render.
React 18.3.1 was still being installed even after changing the version to 19.0.0 in package.json at the root node_modules. This made storybook throw tons of errors related to multiple versions of react present. Resolved it by running npm install --legacy-peer-deps as the error came from @orama/react-components not supporting 19.0.0. This install command is a bit risky though since it updated lots of other packages in package-lock.json, but overall seemed okay.
After this, storybook started complaining and wasn't compiling anymore, giving an error that it wasn't able to find react. After some investigation, realized it was looking for react at the root node_modules instead of node_modules at apps/site. Quick fix was to add react and react-dom with version 19.0.0 to root package.json which created a copy of react and react-dom in the root node modules.
I think we should hold onto the upgrade before storybook releases the version 8.5.0, and @orama/react-components updates the peer dependency for react 19 support.
We want to keep us up to date with our framework we need to upgrade react to
v19
.But let's look at the known problems that are blocking us:
@orama/[email protected]
who don't have react 19 supported in peerdep@storybook/react
may have issue with react 19The text was updated successfully, but these errors were encountered: