Draft: Add field to NooBaa's CR to override environment variables of pods #1510
+76
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This is a proposal to add a envVariablesOverride field to NooBaa's CR in order to customize some environment variables for all NooBaa's pods (right now only "core" sts and "endpoint" deploy pods have been tested and work)
This would allow for example overriding CONFIG_JS_ variables without having to rebuild a custom image on each release.
Currently, the new CR is defined like so, but happy to use another format if you have a better idea:
Right now, all env variables containers of a single pod are overriden (it is not on a per-container basis).
Variables defined in envVariablesOverride have priority over all variables set by the operator in case of a conflict.
Issues:
Testing Instructions: