From 405122de89bc6586a768f357b39aa191b8d659cb Mon Sep 17 00:00:00 2001 From: Dan Lewis Date: Wed, 12 Apr 2023 20:22:06 -0500 Subject: [PATCH 1/2] stop mutating options prop in react component --- src/Cleave.react.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Cleave.react.js b/src/Cleave.react.js index 58d468dc..82f2bbde 100644 --- a/src/Cleave.react.js +++ b/src/Cleave.react.js @@ -70,9 +70,11 @@ var cleaveReactClass = CreateReactClass({ options = {}; } - options.initValue = value; - - owner.properties = DefaultProperties.assign({}, options); + owner.properties = DefaultProperties.assign( + {}, + Object.assign({}, options, { initValue: value }) + ); + return { value: owner.properties.result, From 4b1ba360cfd62ad0dea7d7f2f629c71fb51d22ad Mon Sep 17 00:00:00 2001 From: Daniel Lewis Date: Thu, 13 Apr 2023 14:40:06 -0500 Subject: [PATCH 2/2] Update src/Cleave.react.js Co-authored-by: Monroe Ekilah --- src/Cleave.react.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Cleave.react.js b/src/Cleave.react.js index 82f2bbde..8dadac6b 100644 --- a/src/Cleave.react.js +++ b/src/Cleave.react.js @@ -72,6 +72,7 @@ var cleaveReactClass = CreateReactClass({ owner.properties = DefaultProperties.assign( {}, + // avoid mutating the `options` prop directly Object.assign({}, options, { initValue: value }) );