Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please explain, or add link to references #5

Open
jkomyno opened this issue Feb 4, 2017 · 1 comment
Open

Please explain, or add link to references #5

jkomyno opened this issue Feb 4, 2017 · 1 comment

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Feb 4, 2017

Here I'd like to point out that your Medium tutorial is not a tutorial by itself, at the moment it's just a bunch of code mirrored from GitHub. Mind you, I'm not telling this for the sake of blaming your (hard) job, but as you have pointed out at the end of the post, you didn't explain a lot of niches.

"I am so sorry, because I can’t explain this tutorial clearly."

So I'm opening this issue to invite the community to contribute with guided comments or links. Have a nice day!
@abiemann
Copy link

It would also be good to see some tests because a huge benefit of an architecture is to test thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abiemann @jkomyno