From 61815929d7534e91d0659b3e0098ac2ab51b98ff Mon Sep 17 00:00:00 2001
From: Nicholas Cunningham <ndcunningham@gmail.com>
Date: Mon, 13 Jan 2025 10:20:50 -0700
Subject: [PATCH] fix(js): improve error handling during SWC compilation
 (#29605)

Improves our error handling for swc when using `@nx/js:swc` executor

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
The executor fails to build if the workspace has a newer versions of
`@swc/cli` e.g.(`0.6.0`) is installed since it now uses stderr instead
of message to log errors.
RE: https://github.com/swc-project/pkgs/pull/53

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
The executor should pass in this scenario.


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #29599
---
 packages/js/src/utils/swc/compile-swc.ts | 26 ++++++++++++++++--------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/packages/js/src/utils/swc/compile-swc.ts b/packages/js/src/utils/swc/compile-swc.ts
index e8c83cb48b443..fbb4a4f70439d 100644
--- a/packages/js/src/utils/swc/compile-swc.ts
+++ b/packages/js/src/utils/swc/compile-swc.ts
@@ -86,17 +86,25 @@ export async function compileSwc(
     rmSync(normalizedOptions.outputPath, { recursive: true, force: true });
   }
 
-  const swcCmdLog = execSync(getSwcCmd(normalizedOptions), {
-    encoding: 'utf8',
-    cwd: normalizedOptions.swcCliOptions.swcCwd,
-    windowsHide: false,
-  });
-  logger.log(swcCmdLog.replace(/\n/, ''));
-  const isCompileSuccess = swcCmdLog.includes('Successfully compiled');
+  try {
+    const swcCmdLog = execSync(getSwcCmd(normalizedOptions), {
+      encoding: 'utf8',
+      cwd: normalizedOptions.swcCliOptions.swcCwd,
+      windowsHide: false,
+      stdio: 'pipe',
+    });
+    logger.log(swcCmdLog.replace(/\n/, ''));
+  } catch (error) {
+    logger.error('SWC compilation failed');
+    if (error.stderr) {
+      logger.error(error.stderr.toString());
+    }
+    return { success: false };
+  }
 
   if (normalizedOptions.skipTypeCheck && !normalizedOptions.isTsSolutionSetup) {
     await postCompilationCallback();
-    return { success: isCompileSuccess };
+    return { success: true };
   }
 
   const { errors, warnings } = await runTypeCheck(
@@ -111,7 +119,7 @@ export async function compileSwc(
 
   await postCompilationCallback();
   return {
-    success: !hasErrors && isCompileSuccess,
+    success: !hasErrors,
     outfile: normalizedOptions.mainOutputPath,
   };
 }