Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create initial validation logic for configuration structs. #21

Open
Klaven opened this issue Feb 24, 2023 · 3 comments
Open

Create initial validation logic for configuration structs. #21

Klaven opened this issue Feb 24, 2023 · 3 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@Klaven
Copy link
Contributor

Klaven commented Feb 24, 2023

We have a validation interface that should be implemented on all the configuration structs. Lets start with Stations and validate that the station has at least one step.

Initial implementation on Pipeline struct is here: Validation logic
pipeline's validate fn should be updated to call validate on sub stations

Please ask @Klaven if you have any questions!

@Klaven Klaven added the good first issue Good for newcomers label Feb 24, 2023
@Klaven Klaven added this to the PoC milestone Feb 24, 2023
@salasberryfin
Copy link

Hey @Klaven!

Maybe I can give this one a go. I think I mentioned on Discord that I'm a Rust newbie but, if this is a good first issue, I'd like to work on it.

Any extra help is welcome!

@Klaven
Copy link
Contributor Author

Klaven commented Mar 12, 2023

@salasberryfin Sorry I was sick last week so I am behind on some things but 100% give it a try! if you would like help on it, ask during one of my streams and I would love to step you though what is there! I updated the issue to link to the current implementation that you can just add on to! Thanks for picking this up!

@salasberryfin
Copy link

Hi @Klaven,

Thanks! I'll give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants