Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete a driver who has completed all his tasks. #4211

Open
nus-pe-bot opened this issue Nov 15, 2019 · 1 comment
Open

Unable to delete a driver who has completed all his tasks. #4211

nus-pe-bot opened this issue Nov 15, 2019 · 1 comment

Comments

@nus-pe-bot
Copy link

image.png

Driver 4, Russell has completed all his deliveries, but I am unable to delete him. It matches the error message, but does not make sense feature wise. Furthermore in the user guide, it also states that we should only be unable to delete from ongoing tasks, not completed tasks.

image.png


[original: nus-cs2103-AY1920S1/pe-interim#4233]
@tysg
Copy link

tysg commented Nov 18, 2019

Team's Response

Thanks for your response.

This is a expected behaviour because the completed tasks contains the data of the driver therefore, it cannot be deleted. If you were to delete the driver, then you will not know who delivered those completed tasks before.

I marked it as a featureflaw as there can be a better method to handle the driver data such as storing them as archive

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants