Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Script no longer working with NZBget Docker image #11

Open
rosarch opened this issue Jun 14, 2020 · 8 comments · May be fixed by #12
Open

Script no longer working with NZBget Docker image #11

rosarch opened this issue Jun 14, 2020 · 8 comments · May be fixed by #12

Comments

@rosarch
Copy link

rosarch commented Jun 14, 2020

The linuxserver nzbget docker image (https://hub.docker.com/r/linuxserver/nzbget/) has been updated, they have dropped support for python 2.

The result of this is a broken script which no longer works with nzbget.

It will be great if someone with Python skills can update the script to be python 3 compatible.

@dmce
Copy link

dmce commented Jun 19, 2020

As a short term fix you have 2 options:

Copy the script into here and use the converted version: https://www.pythonconverter.com/
Customise the linuxserver nzbget image: https://blog.linuxserver.io/2019/09/14/customizing-our-containers/

I used the first option and the script is at least running successfully

@rojaxthegreat
Copy link

As a short term fix you have 2 options:

Copy the script into here and use the converted version: https://www.pythonconverter.com/
Customise the linuxserver nzbget image: https://blog.linuxserver.io/2019/09/14/customizing-our-containers/

I used the first option and the script is at least running successfully

Thanks man

@rosarch
Copy link
Author

rosarch commented Jun 21, 2020

Converting the scripts sounds like the easiest option, I did this via the pythonconverter site but still get a load of errors, is there anything else that needs to be done as well as the script conversion?

If I cant get it working I will go down the route of the second option.

@simoncaron
Copy link

@rosarch I updated the script to be Python3 compliant here, everything seems good on my side: https://github.com/skaro13/FakeDetector/blob/feature/python3-support/FakeDetector.py

@rosarch
Copy link
Author

rosarch commented Jun 29, 2020

@skaro13 - Thanks, worked a treat!

@jpartain89
Copy link

@skaro13 have you thought about trying to pull request that against this repo, so we all could benefit from it?

@nemchik
Copy link

nemchik commented Aug 19, 2020

@rosarch if you click here https://github.com/nzbget/FakeDetector/compare/nzbget:master...skaro13:feature/python3-support?expand=1 you can then just click the green button to Create pull request. Hopefully the maintainers here will accept it.

@nemchik
Copy link

nemchik commented Aug 19, 2020

Also to anyone who has cloned this repo for now you can pretty easily run:

git remote add skaro13 https://github.com/skaro13/FakeDetector.git
git fetch -p --all
git checkout skaro13/feature/python3-support

and then if that ever gets merged into this repo you can get switched back with:

git fetch -p --all
git reset --hard origin/master

@simoncaron simoncaron linked a pull request Nov 29, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants