Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace/enhance isX patterns with SWRL rules, e.g. for phosphorylates #259

Open
cmungall opened this issue Sep 25, 2018 · 10 comments
Open
Labels
enhancement rule Has something to do with rules or axioms

Comments

@cmungall
Copy link
Contributor

Example:
http://purl.obolibrary.org/obo/RO_0002447

has axiom:

(capable of o is kinase activity o has direct input) subPropertyOf phosphorylates

this infers entity-entity precise relationships given a GO-CAM pattern

this pattern is familiar to owl ultra-geeks but is probably bamboozling to others. It doesn't help that ontobee doesn't show self-reflexivity axiom for http://purl.obolibrary.org/obo/RO_0002481. Another issue is that this is not in EL.

It would be cleaner to write this as a SWRL rule. We can have an optional transform to the self-reflexive pattern.

thoughts @balhoff ?

@cmungall
Copy link
Contributor Author

?a1 enabled_by ?gp1
?gp1 a GO:'kinase activity'
?a1 directly-regulates ?a2
?a2 enabled-by ?gp2
->
?gp1 phosphorylates ?gp2

similar pattern for ubiquitination etc

@balhoff
Copy link
Member

balhoff commented Sep 26, 2018

I agree the SWRL rule is less mysterious and would actually be supported in some GO reasoning situations (Arachne or Whelk). However it wouldn't contribute to Tbox classification; maybe this doesn't matter since the current Self axiom isn't either. ObjectHasSelf is supposed to be in EL, but as you say ELK doesn't support it (I checked 0.5 also).

@cmungall
Copy link
Contributor Author

Good point. Still useful for a lot of ABox use cases.

@cthoyt
Copy link
Collaborator

cthoyt commented Sep 27, 2018

I noticed that the only two post-translational modifications available in OBO-RO are phosphorylates and ubiquitinates. Is it non-trivial to add more of these relationships if they're being defined this way?

I'm interested in this because we capture several more PTMs in BEL (amination, nitration, nitrosylation, glycation, etc.) that live under the GO term cellular protein modification process (GO:0006464). I'm not (yet) an ultra-geek, but it seems like defining more of these using this SWRL rule might not be so difficult.

Should I make a new issue to continue this discussion?

@cmungall
Copy link
Contributor Author

Is it non-trivial to add more of these relationships if they're being defined this way?

Trivial but a bit tedious. I think we should try and devote a couple of hours to getting our templating framework set up so this becomes a matter of filling in terms in a CSV. @balhoff would dosdp-tools/spec require any work to include SWRL?

Yes, go ahead and make a new ticket, thanks!

@dosumis
Copy link
Contributor

dosumis commented Sep 28, 2018 via email

@nlharris
Copy link
Contributor

nlharris commented Jan 6, 2022

Is this still needed (and if so, who could work on it)?

@cthoyt
Copy link
Collaborator

cthoyt commented Jan 6, 2022

This is related to #522, which will get some discussion at the RO meeting next week

Copy link
Contributor

This issue has not seen any activity in the past 2 years. It will be closed automatically 60 days from now if no action is taken.

@github-actions github-actions bot added the stale label Feb 15, 2025
@cthoyt
Copy link
Collaborator

cthoyt commented Feb 15, 2025

I'm still interested in this

@github-actions github-actions bot removed the stale label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement rule Has something to do with rules or axioms
Projects
None yet
Development

No branches or pull requests

5 participants