Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old domainslib cannot compile with released ocaml 5.0 #23790

Open
mseri opened this issue May 15, 2023 · 3 comments
Open

Old domainslib cannot compile with released ocaml 5.0 #23790

mseri opened this issue May 15, 2023 · 3 comments

Comments

@mseri
Copy link
Member

mseri commented May 15, 2023

Should we mark them as unavailable?


#=== ERROR while compiling domainslib.0.3.0 ===================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.5.0.0 | file:///home/opam/opam-repository
# path                 ~/.opam/5.0/.opam-switch/build/domainslib.0.3.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p domainslib -j 127
# exit-code            1
# env-file             ~/.opam/log/domainslib-7-83a762.env
# output-file          ~/.opam/log/domainslib-7-83a762.out
### output ###
# (cd _build/default && /home/opam/.opam/5.0/bin/ocamlc.opt -w -40 -g -bin-annot -I lib/.domainslib.objs/byte -no-alias-deps -open Domainslib__ -o lib/.domainslib.objs/byte/domainslib__Ws_deque.cmo -c -impl lib/ws_deque.ml)
# File "lib/ws_deque.ml", line 192, characters 8-29:
# 192 |         Domain.Sync.cpu_relax ();
#               ^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound module Domain.Sync

ping @samoht

@avsm
Copy link
Member

avsm commented May 15, 2023

/cc @kayceesrk -- it can probably just depend on the 4.14+domains compiler I suspect.

@kayceesrk
Copy link
Contributor

it can probably just depend on the 4.14+domains compiler I suspect.

Agreed. @Sudha247 has been maintaining domainslib. Sudha, please can you have a look?

@Sudha247
Copy link
Contributor

I had a quick look - Domain.Sync.cpu_relax was deprecated in 4.12.0+domains in favour of Domain.cpu_relax. Previous versions of the multicore compiler are not available in opam-repository. We should just mark it as unavailable, I think. Will send in a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants