fix: support setting authStrategy using .withDefaults({ authStrategy })
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
20/withDefaults-authStrategy
branch
from
c6fff1d to
70ceeba
Compare
gr2m
force-pushed
the
20/withDefaults-authStrategy
branch
from
53647f8 to
1374eac
Compare
…tructorRequiringOptionsIfNeeded` / `RequiredIfRemaining`
gr2m
force-pushed
the
20/withDefaults-authStrategy
branch
from
781733c to
d46e4a1
Compare
…t needs to work correctly (show TS error)
gr2m
force-pushed
the
20/withDefaults-authStrategy
branch
from
4a9741f to
742a365
Compare
…set using `.withDefaults`
gr2m
force-pushed
the
20/withDefaults-authStrategy
branch
from
b693e84 to
196229e
Compare
|
I got it as close as I could, unfortunately not fully working :( I'll make a follow up issue and add the limitation to a "known issues" section in the README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20