🧐 Incorrect type definition for "hooks" callback in v16 index.d.ts?

[douglascayers]

We are still using v16.43.1 of this incredible library and for "insert reasons here" we aren't able to prioritize upgrading to v17 or later version. With that in mind, I've come across an issue using hook.wrap('request', callback) method on Octokit client defined here.

At line 33,707 the return type for the callback passed to wrap is void as shown below:

But examples here and here show that the callback should return something.

In typescript, it or my linter, is complaining that I can't return something from a method expected to be void.

I think line 33,707 should have Promise<Octokit.Response<any>> return type since it'd be returning what the request function argument returns, correct?

If that's the case, would you be able to release a minor or patch release of the v16 line? Since index.d.ts is generated, I think the actual code change would occur in scripts/update-endpoints/templates/index.d.ts.tpl at line 323.

Thanks!

[gr2m]

Thanks Doug for reporting the issue. The "wrap" hook needs to indeed return something, while the others don't have to, I'll look into it

[gr2m]

See my pull request at https://github.com/octokit/rest.js/pull/1770