-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Network Errors have statusCode 500 #713
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Is there a good way to tell these network 500s from legit 500s on the current version? I'm trying to debug some 500 errors that come back as: "Error: Unhandled error: HttpError: Unexpected end of JSON input". This is in a github actions environment using https://github.com/actions/github-script 7.0.1
This same request works just fine on curl from my dev machine. Makes me think there is some kind of network issue but the 500 error status code is throwing me for a loop |
What happened?
When there are network errors, the status code is 500. I think it would be better to set the status code to 0 indicating that the request has errored not because of some dubious internal server error on the remote, but because of some network issue
I think we should then increment the version by a major.
Versions
v. 9.1.1
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: