Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vane Permission - Usage Problems #286

Open
compinerd opened this issue Jan 3, 2025 · 3 comments
Open

Vane Permission - Usage Problems #286

compinerd opened this issue Jan 3, 2025 · 3 comments

Comments

@compinerd
Copy link

compinerd commented Jan 3, 2025

Been trying to set up Vane Permission Plugin, basically you can only change the permissions in the vane-permissions\config.yml if i understand that correctly. And then assign with perms add <user> <group> which saves to storage.json.
A few issues that i've come across with, when trying to set it up were:

Major problems

  • adding a new group directly to the config.yml, following vane reload, causes the permissions plugin to crash and not being responsive anymore through the console
  • if you don't strictly upkeep the [ - permission] syntax, not enough spaces for example, it causes the server to immediately shutdown after its start without any error message indicating as to why
  • perm list groups <user> (trying to check group affiliation) causes the plugin to runs into an error (see below) and be unresponsive (needs restart)

Minor Problems

  • the command perm list permissions <user> suggests an option to directly assign permissions to a user, but there's no documentation available as to how such a feature could be used

  • right now the only option to change permissions (by editing the config.yml) requires a server restart to apply them (see first issue), this makes maintaining the server and its plugins a lot more time costly.

Error Message after perm list groups <user>
Command exception: /perm list groups .Robin java.lang.ClassCastException: class com.destroystokyo.paper.console.TerminalConsoleCommandSender cannot be cast to class org.bukkit.entity.Player (com.destroystokyo.paper.console.TerminalConsoleCommandSender and org.bukkit.entity.Player are in unnamed module of loader java.net.URLClassLoader @3b764bce) at vane-permissions-1.17.2.jar/org.oddlama.vane.permissions.commands.Permission.sender(Permission.java:157) ~[vane-permissions-1.17.2.jar:?] at vane-permissions-1.17.2.jar/org.oddlama.vane.permissions.commands.Permission.lambda$get_command_base$1(Permission.java:86) ~[vane-permissions-1.17.2.jar:?] at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?] at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:30) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:105) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:435) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.Commands.performCommand(Commands.java:342) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.Commands.performCommand(Commands.java:332) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.commands.Commands.performPrefixedCommand(Commands.java:320) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at org.bukkit.craftbukkit.command.VanillaCommandWrapper.execute(VanillaCommandWrapper.java:56) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:165) ~[paper-api-1.21.4-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:1015) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at org.bukkit.craftbukkit.CraftServer.dispatchServerCommand(CraftServer.java:1000) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.server.dedicated.DedicatedServer.handleConsoleInputs(DedicatedServer.java:478) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.server.dedicated.DedicatedServer.tickConnection(DedicatedServer.java:428) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1737) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1529) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1251) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:310) ~[paper-1.21.4.jar:1.21.4-71-83995d7e] at java.base/java.lang.Thread.run(Thread.java:1575) ~[?:?]

@compinerd compinerd changed the title Vane Permission - Bug Vane Permission - Usage Problems Jan 3, 2025
@oddlama
Copy link
Owner

oddlama commented Jan 3, 2025

Been trying to set up Vane Permission Plugin, basically you can only change the permissions in the vane-permissions\config.yml if i understand that correctly.

Yes that's true. It really was intended as a very barebones plugin for small servers that only need a basic way to declare permissions, and don't want to use a complex and more fully featured plugin like LuckPerms.

Major problems

* adding a new group directly to the config.yml, following `vane reload`, causes the permissions plugin to crash and not being responsive anymore through the console

That's not great of course. I think adding the reload command was a mistake on my side, since the general wisdom says to always restart and never reload. Even the server-provided /reload is fundamentally broken and should be avoided at all times. I know it's convenient, but it's too hard to get right in a complex system. If you want to add permissions dynamically, LuckPerms is probably better suited for this.

* if you don't strictly upkeep the [  - permission] syntax, not enough spaces for example, it causes the server to immediately shutdown after its start without any error message indicating as to why

Are you sure there is no message? The code contains a message that should say Invalid plugin configuration. Shutting down.. Vane just is pedantic and doesn't allow your server to continue running if the configuration syntax is invalid. We can't provide more information than that, since the configuration loader is part of the server software, not vane. We only know that it failed to load.

* `perm list groups <user>` (trying to check group affiliation) causes the plugin to runs into an error (see below) and be unresponsive (needs restart)

Will have a look at this, this shouldn't happen (obviously 😅)

Minor Problems

* the command `perm list permissions <user>` suggests an option to directly assign permissions to a user, but there's no documentation available as to how such a feature could be used

* right now the only option to change permissions (by editing the config.yml) requires a server restart to apply them (see first issue), this makes maintaining the server and its plugins a lot more time costly.

If you want to make frequent changes, please consider using another permissions plugin. This is not what vane-permissions is intended for.

@compinerd
Copy link
Author

i was using luck perms at first but generally i like the idea of vane-permissions and after setting it up it works fine, just getting there is a bit rough
i was just confused with the documentation as it said that "these 8 permissions you should set, but we can't go into detail into all of them", i just didn't want to run into issues with vane as i think the variety of improvements it offers is vastly worth a lot.

Been trying to set up a vanialla like survival server but still i wanna add as much as cool stuff as possible. so even if this is maybe not the right place for it - Great job so far, we're really enjoying the things vane brought into the game!

@oddlama
Copy link
Owner

oddlama commented Jan 4, 2025

i was just confused with the documentation as it said that "these 8 permissions you should set, but we can't go into detail into all of them"

If I'm not mistaken the documentation is saying that we cannot go into detail on how you would set these permissions in a specific permissions plugin, since there are just so many permissions plugins that it would be too much to write in the docs. So instead we give you the list of permissions you have to set, and you have to know how to do that in the permissions plugin you chose. There's really not much detail to the permissions itself. They are usually quite descriptive. If any are unclear let me know.

Been trying to set up a vanialla like survival server but still i wanna add as much as cool stuff as possible. so even if this is maybe not the right place for it - Great job so far, we're really enjoying the things vane brought into the game!

Thanks, glad you are enjoying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants