Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IPFS add and cat calls more asynchronous through threading #379

Open
machawk1 opened this issue Feb 1, 2018 · 5 comments
Open

Make IPFS add and cat calls more asynchronous through threading #379

machawk1 opened this issue Feb 1, 2018 · 5 comments

Comments

@machawk1
Copy link
Member

machawk1 commented Feb 1, 2018

Both replay and indexer perform IPFS.cat() and IPFS.add() for each of the header and the payload in series. A potential optimization exists in threading these two calls with a timeout instead of using a timer (SIGALARM in the case of the replay). This has the potential to have big ramifications, as the process is executed for each embedded resource as well on replay.

/cc @ibnesayeed

@machawk1
Copy link
Member Author

machawk1 commented Feb 7, 2018

Some of the promise-esque constructs are only available in fairly modern version of Py3.

@DonaldTsang
Copy link

DonaldTsang commented Jun 8, 2018

@machawk1 Maybe this can be helped too #388

@ibnesayeed
Copy link
Member

@DonaldTsang: Maybe this can help too #388

I can't see how this ticket is related to the referenced request.

@DonaldTsang
Copy link

Sorry, that was a typo, I was meant to say that Async can be combined used for #388

@machawk1
Copy link
Member Author

A relevant repo for benchmarking IPFS (js implementation cf. go implementation) is also in-the-works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants